From: Tony Lindgren <tony@atomide.com>
To: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
lee.jones@linaro.org, sameo@linux.intel.com,
linux-gpio@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: Use of pinctrl-single for external device over I2C
Date: Wed, 24 Jun 2015 06:33:50 -0700 [thread overview]
Message-ID: <20150624133349.GI4156@atomide.com> (raw)
In-Reply-To: <558A9CC7.6070409@linaro.org>
* Vaibhav Hiremath <vaibhav.hiremath@linaro.org> [150624 05:06]:
> On Tuesday 23 June 2015 04:25 PM, Vaibhav Hiremath wrote:
> >
> >/*
> > * REVISIT: Reads and writes could eventually use regmap or something
> > * generic. But at least on omaps, some mux registers are performance
> > * critical as they may need to be remuxed every time before and after
> > * idle. Adding tests for register access width for every read and
> > * write like regmap is doing is not desired, and caching the registers
> > * does not help in this case.
> > */
> >
> >
> >Should be not have flag for this and use regmap_ variants? If we
> >implement flag based approach then same driver can be reused for pinmux
> >configuration of external device.
Nothing stopping you from adding regmap support to it. It just needs
to be made optional as the users so far don't need it.
Regards,
Tony
next prev parent reply other threads:[~2015-06-24 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 10:55 Use of pinctrl-single for external device over I2C Vaibhav Hiremath
2015-06-24 12:04 ` Vaibhav Hiremath
2015-06-24 13:33 ` Tony Lindgren [this message]
2015-06-24 17:10 ` Vaibhav Hiremath
2015-06-25 4:38 ` Tony Lindgren
2015-06-25 5:46 ` Vaibhav Hiremath
2015-06-30 7:46 ` Vaibhav Hiremath
2015-06-30 7:58 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624133349.GI4156@atomide.com \
--to=tony@atomide.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=vaibhav.hiremath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).