From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
nicolas.ferre@atmel.com
Subject: Re: [RFC PATCH 0/3] New Atmel PIO4 pinctrl/gpio driver
Date: Wed, 5 Aug 2015 09:31:17 +0200 [thread overview]
Message-ID: <20150805073117.GP5161@pengutronix.de> (raw)
In-Reply-To: <1438355290-28255-1-git-send-email-ludovic.desroches@atmel.com>
On Fri, Jul 31, 2015 at 05:08:07PM +0200, Ludovic Desroches wrote:
> Hi,
>
> Following our discussion, I send an RFC version of my driver. RFC because it is
> not totally achieved, some cleanup and feature addition is needed.
>
> At least, we could discuss about the 'core' part. I have used the pinmux
> property as Mediatek driver. Patch 3 is the internal dt files we are using.
As you can imagine I am fine with the binding, so I can add my acked-by
once you send a non-RFC version.
The only thing I never understood is what's so special about GPIOs that
they have to bypass the pinctrl framework and instead a gpio_request
magically translates a gpio into a pin. Wouldn't it make sense to at
least add the pins in their GPIO mode to
arch/arm/boot/dts/sama5d2-pinfunc.h?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2015-08-05 7:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 15:08 [RFC PATCH 0/3] New Atmel PIO4 pinctrl/gpio driver Ludovic Desroches
2015-07-31 15:08 ` [RFC PATCH 1/3] pinctrl: introduce driver for Atmel PIO4 controller Ludovic Desroches
2015-07-31 15:08 ` [RFC PATCH 2/3] ARM: at91/dt: add sama5d2 pinmux Ludovic Desroches
2015-08-03 6:40 ` Josh Wu
2015-08-03 6:59 ` Ludovic Desroches
2015-07-31 15:08 ` [RFC PATCH 3/3] ARM: at91/dt: add pinctrl Ludovic Desroches
2015-08-05 7:31 ` Sascha Hauer [this message]
2015-08-10 6:53 ` [RFC PATCH 0/3] New Atmel PIO4 pinctrl/gpio driver Ludovic Desroches
2015-08-20 7:05 ` Sascha Hauer
2015-08-20 12:44 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805073117.GP5161@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).