From: Dan Carpenter <dan.carpenter@oracle.com>
To: grygorii.strashko@ti.com
Cc: linux-gpio@vger.kernel.org
Subject: re: gpio: omap: switch to use platform_get_irq
Date: Mon, 21 Sep 2015 19:26:45 +0300 [thread overview]
Message-ID: <20150921162645.GF5648@mwanda> (raw)
Hello Grygorii Strashko,
The patch 89d18e3af8b9: "gpio: omap: switch to use platform_get_irq"
from Aug 18, 2015, leads to the following static checker warning:
drivers/gpio/gpio-omap.c:1191 omap_gpio_probe()
warn: assigning (-6) to unsigned variable 'bank->irq'
drivers/gpio/gpio-omap.c
1188 bank->irq = platform_get_irq(pdev, 0);
1189 if (bank->irq <= 0) {
bank->irq is u16.
1190 if (!bank->irq)
1191 bank->irq = -ENXIO;
Does not work.
1192 if (bank->irq != -EPROBE_DEFER)
Does not work.
1193 dev_err(dev,
1194 "can't get irq resource ret=%d\n", bank->irq);
1195 return bank->irq;
1196 }
regards,
dan carpenter
reply other threads:[~2015-09-21 16:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921162645.GF5648@mwanda \
--to=dan.carpenter@oracle.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox