linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* re: gpio: omap: switch to use platform_get_irq
@ 2015-09-21 16:26 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-09-21 16:26 UTC (permalink / raw)
  To: grygorii.strashko; +Cc: linux-gpio

Hello Grygorii Strashko,

The patch 89d18e3af8b9: "gpio: omap: switch to use platform_get_irq"
from Aug 18, 2015, leads to the following static checker warning:

	drivers/gpio/gpio-omap.c:1191 omap_gpio_probe()
	warn: assigning (-6) to unsigned variable 'bank->irq'

drivers/gpio/gpio-omap.c
  1188          bank->irq = platform_get_irq(pdev, 0);
  1189          if (bank->irq <= 0) {

bank->irq is u16.

  1190                  if (!bank->irq)
  1191                          bank->irq = -ENXIO;

Does not work.

  1192                  if (bank->irq != -EPROBE_DEFER)

Does not work.

  1193                          dev_err(dev,
  1194                                  "can't get irq resource ret=%d\n", bank->irq);
  1195                  return bank->irq;
  1196          }


regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-09-21 16:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-21 16:26 gpio: omap: switch to use platform_get_irq Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).