From: Andreas Werner <andy@wernerandy.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Johannes Thumshirn <morbidrsa@gmail.com>
Subject: Re: [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller
Date: Thu, 8 Oct 2015 21:49:26 +0200 [thread overview]
Message-ID: <20151008194926.GA10709@linux-rrhd.site> (raw)
In-Reply-To: <CACRpkdZhdf787xAH-AY=8fY3YXOuLriVXhJHAn554YFWtDYZ7g@mail.gmail.com>
Yet another thing.
if i will implement the open drain support, does it really makes sense to go with the
generic gpio lib?
I need to replace the direction_input and direction_outpu functions
because if the userland set an open drain pin to input i need to
set the pin to High-Z (driver "1") instead of setting the input bit
in the direction register.
So at the end there are just the "set" and "dat"
functions used to drive an output and to get an input state.
Alle other functions needs to be implemented in the driver.
Regards
Andy
next prev parent reply other threads:[~2015-10-08 19:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 18:09 [PATCH] gpio: Add driver for MEN 16Z127 GPIO controller Andreas Werner
2015-10-06 7:35 ` Linus Walleij
2015-10-06 17:54 ` Andreas Werner
2015-10-08 16:55 ` Andreas Werner
2015-10-16 19:51 ` Linus Walleij
2015-10-08 19:49 ` Andreas Werner [this message]
2015-10-16 19:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008194926.GA10709@linux-rrhd.site \
--to=andy@wernerandy.de \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbidrsa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).