* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
[not found] ` <1444684386-17094-1-git-send-email-laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
@ 2015-10-12 21:46 ` Tony Lindgren
2015-10-12 22:19 ` Javier Martinez Canillas
2015-10-13 6:19 ` Sascha Hauer
2015-10-13 14:09 ` Shawn Guo
2 siblings, 1 reply; 9+ messages in thread
From: Tony Lindgren @ 2015-10-12 21:46 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Benoit Cousson, Jason Cooper,
Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Kukjin Kim,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Stephen Warren,
Thierry Reding, Alexandre Courbot, Liam Girdwood, Mark Brown,
Linus Walleij, Javier Martinez Canillas
* Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> [151012 14:17]:
> Hello,
>
> While working on regulators, GPIOs and DT I noticed that many of our DT source
> files incorrectly describe fixed regulators. The common error patterns are
>
> - Usage of the undefined (and never parsed) enable-active-low property
> - Usage of the enable-active-high property without specifying an enable GPIO
> - Typos in the enabl GPIO property name (gpios instead of gpio)
> - Mismatch between the enable-active-high property (or the lack thereof) and
> the enable GPIO flags
>
> This patch series fixes those issues in all the DT sources after locating the
> errors using the following script.
>
> ------------------------------------------------------------------------------
> #!/bin/sh
>
> echo $1
> cat $1 | awk '
> BEGIN {
> open_drain = 0;
> active_high = 0;
> gpio = 0;
> flags = 0;
> }
>
> match($0, /([a-zA-Z0-9@_-]*) {/, ary) {
> name = ary[1];
> }
>
> /compatible.*"regulator-fixed"/ {
> found = 1;
> }
>
> /enable-active-high/ {
> active_high = 1;
> }
>
> /gpio-open-drain/ {
> open_drain = 1;
> }
>
> match($0, /gpio += <.* ([^ ]*)>/, ary) {
> gpio = 1;
> flags = ary[1];
> if (flags == 0)
> flags = "GPIO_ACTIVE_HIGH";
> }
>
> /}/ {
> if (found) {
> if (gpio) {
> print "\t" name ": active high " active_high " " flags " open drain " open_drain;
> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
> print "WARNING: enable-active-high and flags do not match"
> } else {
> if (active_high)
> print "WARNING: active high without GPIO"
> if (open_drain)
> print "WARNING: open drain without GPIO"
> }
> }
>
> gpio = 0;
> found = 0;
> active_high = 0;
> open_drain = 0;
> flags = 0;
> }
> '
> ------------------------------------------------------------------------------
>
> All patches except for the ones touching omap3-beagle-xm and omap3-overo-base
> are untested as I lack test hardware.
>
> As there's no dependency between the patches touching different source files
> the appropriate maintainers could take their share of the patches in their
> tree. Alternatively I could send a single pull request after collecting all
> acks but that might be more complex.
Nice clean-up. For omaps, there's an earlier patch posted by
Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> as "[PATCH] ARM: dts: Use
defined GPIO constants in flags cell for OMAP2+ boards". Can you guys do some
cross checking and let me know which combination I should appluy for omaps?
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-12 21:46 ` Tony Lindgren
@ 2015-10-12 22:19 ` Javier Martinez Canillas
2015-10-12 22:22 ` Laurent Pinchart
0 siblings, 1 reply; 9+ messages in thread
From: Javier Martinez Canillas @ 2015-10-12 22:19 UTC (permalink / raw)
To: Tony Lindgren, Laurent Pinchart
Cc: linux-arm-kernel, devicetree, linux-omap, linux-samsung-soc,
linux-tegra, linux-gpio, linux-kernel, Benoit Cousson,
Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
Kukjin Kim, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Stephen Warren, Thierry Reding, Alexandre Courbot, Liam Girdwood,
Mark Brown, Linus Walleij
Hello Tony,
On 10/12/2015 11:46 PM, Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 14:17]:
>> Hello,
>>
>> While working on regulators, GPIOs and DT I noticed that many of our DT source
>> files incorrectly describe fixed regulators. The common error patterns are
>>
>> - Usage of the undefined (and never parsed) enable-active-low property
>> - Usage of the enable-active-high property without specifying an enable GPIO
>> - Typos in the enabl GPIO property name (gpios instead of gpio)
>> - Mismatch between the enable-active-high property (or the lack thereof) and
>> the enable GPIO flags
>>
>> This patch series fixes those issues in all the DT sources after locating the
>> errors using the following script.
>>
>> ------------------------------------------------------------------------------
>> #!/bin/sh
>>
>> echo $1
>> cat $1 | awk '
>> BEGIN {
>> open_drain = 0;
>> active_high = 0;
>> gpio = 0;
>> flags = 0;
>> }
>>
>> match($0, /([a-zA-Z0-9@_-]*) {/, ary) {
>> name = ary[1];
>> }
>>
>> /compatible.*"regulator-fixed"/ {
>> found = 1;
>> }
>>
>> /enable-active-high/ {
>> active_high = 1;
>> }
>>
>> /gpio-open-drain/ {
>> open_drain = 1;
>> }
>>
>> match($0, /gpio += <.* ([^ ]*)>/, ary) {
>> gpio = 1;
>> flags = ary[1];
>> if (flags == 0)
>> flags = "GPIO_ACTIVE_HIGH";
>> }
>>
>> /}/ {
>> if (found) {
>> if (gpio) {
>> print "\t" name ": active high " active_high " " flags " open drain " open_drain;
>> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
>> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
>> print "WARNING: enable-active-high and flags do not match"
>> } else {
>> if (active_high)
>> print "WARNING: active high without GPIO"
>> if (open_drain)
>> print "WARNING: open drain without GPIO"
>> }
>> }
>>
>> gpio = 0;
>> found = 0;
>> active_high = 0;
>> open_drain = 0;
>> flags = 0;
>> }
>> '
>> ------------------------------------------------------------------------------
>>
>> All patches except for the ones touching omap3-beagle-xm and omap3-overo-base
>> are untested as I lack test hardware.
>>
>> As there's no dependency between the patches touching different source files
>> the appropriate maintainers could take their share of the patches in their
>> tree. Alternatively I could send a single pull request after collecting all
>> acks but that might be more complex.
>
> Nice clean-up. For omaps, there's an earlier patch posted by
> Javier Martinez Canillas <javier@osg.samsung.com> as "[PATCH] ARM: dts: Use
> defined GPIO constants in flags cell for OMAP2+ boards". Can you guys do some
> cross checking and let me know which combination I should appluy for omaps?
>
Since Laurent's changes for OMAP are part of a bigger series and my patch
was only for OMAP, probably makes sense for you to pick his patches and I
can re-spin mine on top of that.
BTW, I posted as a single patch since the changes were trivial but maybe
that made handling these conflicts harder and I should split the changes
instead, since I'll resend anyways.
What do you prefer? a patch per SoC family (i.e: OMAP{2,3,4,5}) or patch
per board DTS?
> Regards,
>
> Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-12 22:19 ` Javier Martinez Canillas
@ 2015-10-12 22:22 ` Laurent Pinchart
2015-10-12 22:24 ` Tony Lindgren
0 siblings, 1 reply; 9+ messages in thread
From: Laurent Pinchart @ 2015-10-12 22:22 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Tony Lindgren, linux-arm-kernel, devicetree, linux-omap,
linux-samsung-soc, linux-tegra, linux-gpio, linux-kernel,
Benoit Cousson, Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Kukjin Kim, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Stephen Warren, Thierry Reding, Alexandre Courbot,
Liam Girdwood, Mark Brown, Linus Walleij
Hi Javier,
On Tuesday 13 October 2015 00:19:20 Javier Martinez Canillas wrote:
> On 10/12/2015 11:46 PM, Tony Lindgren wrote:
> > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [151012 14:17]:
> >> Hello,
> >>
> >> While working on regulators, GPIOs and DT I noticed that many of our DT
> >> source files incorrectly describe fixed regulators. The common error
> >> patterns are
> >>
> >> - Usage of the undefined (and never parsed) enable-active-low property
> >> - Usage of the enable-active-high property without specifying an enable
> >> GPIO
> >> - Typos in the enabl GPIO property name (gpios instead of gpio)
> >> - Mismatch between the enable-active-high property (or the lack thereof)
> >> and the enable GPIO flags
> >>
> >> This patch series fixes those issues in all the DT sources after locating
> >> the errors using the following script.
> >>
> >> -------------------------------------------------------------------------
> >> !/bin/sh
> >>
> >> echo $1
> >> cat $1 | awk '
> >> BEGIN {
> >> open_drain = 0;
> >> active_high = 0;
> >> gpio = 0;
> >> flags = 0;
> >> }
> >>
> >> match($0, /([a-zA-Z0-9@_-]*) {/, ary) {
> >> name = ary[1];
> >> }
> >>
> >> /compatible.*"regulator-fixed"/ {
> >> found = 1;
> >> }
> >>
> >> /enable-active-high/ {
> >> active_high = 1;
> >> }
> >>
> >> /gpio-open-drain/ {
> >> open_drain = 1;
> >> }
> >>
> >> match($0, /gpio += <.* ([^ ]*)>/, ary) {
> >> gpio = 1;
> >> flags = ary[1];
> >> if (flags == 0)
> >> flags = "GPIO_ACTIVE_HIGH";
> >> }
> >>
> >> /}/ {
> >> if (found) {
> >> if (gpio) {
> >> print "\t" name ": active high " active_high " " flags " open
drain "
> >> open_drain;
> >> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
> >> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
> >> print "WARNING: enable-active-high and flags do not
match"
> >> } else {
> >> if (active_high)
> >> print "WARNING: active high without GPIO"
> >> if (open_drain)
> >> print "WARNING: open drain without GPIO"
> >> }
> >> }
> >>
> >> gpio = 0;
> >> found = 0;
> >> active_high = 0;
> >> open_drain = 0;
> >> flags = 0;
> >> }
> >> '
> >> -------------------------------------------------------------------------
> >>
> >> All patches except for the ones touching omap3-beagle-xm and
> >> omap3-overo-base are untested as I lack test hardware.
> >>
> >> As there's no dependency between the patches touching different source
> >> files the appropriate maintainers could take their share of the patches
> >> in their tree. Alternatively I could send a single pull request after
> >> collecting all acks but that might be more complex.
> >
> > Nice clean-up. For omaps, there's an earlier patch posted by
> > Javier Martinez Canillas <javier@osg.samsung.com> as "[PATCH] ARM: dts:
> > Use defined GPIO constants in flags cell for OMAP2+ boards". Can you guys
> > do some cross checking and let me know which combination I should appluy
> > for omaps?
>
> Since Laurent's changes for OMAP are part of a bigger series and my patch
> was only for OMAP, probably makes sense for you to pick his patches and I
> can re-spin mine on top of that.
>
> BTW, I posted as a single patch since the changes were trivial but maybe
> that made handling these conflicts harder and I should split the changes
> instead, since I'll resend anyways.
>
> What do you prefer? a patch per SoC family (i.e: OMAP{2,3,4,5}) or patch
> per board DTS?
My series will likely miss the next merge window as more discussion is needed.
I'll thus respin the patches on top of yours, please proceed without caring
about this.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-12 22:22 ` Laurent Pinchart
@ 2015-10-12 22:24 ` Tony Lindgren
0 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2015-10-12 22:24 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Javier Martinez Canillas,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Benoit Cousson, Jason Cooper,
Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Kukjin Kim,
Krzysztof Kozlowski, Shawn Guo, Sascha Hauer, Stephen Warren,
Thierry Reding, Alexandre Courbot, Liam Girdwood, Mark Brown,
Linus Walleij
* Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> [151012 15:26]:
> Hi Javier,
>
> On Tuesday 13 October 2015 00:19:20 Javier Martinez Canillas wrote:
> > On 10/12/2015 11:46 PM, Tony Lindgren wrote:
> > > * Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> [151012 14:17]:
> > >> Hello,
> > >>
> > >> While working on regulators, GPIOs and DT I noticed that many of our DT
> > >> source files incorrectly describe fixed regulators. The common error
> > >> patterns are
> > >>
> > >> - Usage of the undefined (and never parsed) enable-active-low property
> > >> - Usage of the enable-active-high property without specifying an enable
> > >> GPIO
> > >> - Typos in the enabl GPIO property name (gpios instead of gpio)
> > >> - Mismatch between the enable-active-high property (or the lack thereof)
> > >> and the enable GPIO flags
> > >>
> > >> This patch series fixes those issues in all the DT sources after locating
> > >> the errors using the following script.
> > >>
> > >> -------------------------------------------------------------------------
> > >> !/bin/sh
> > >>
> > >> echo $1
> > >> cat $1 | awk '
> > >> BEGIN {
> > >> open_drain = 0;
> > >> active_high = 0;
> > >> gpio = 0;
> > >> flags = 0;
> > >> }
> > >>
> > >> match($0, /([a-zA-Z0-9@_-]*) {/, ary) {
> > >> name = ary[1];
> > >> }
> > >>
> > >> /compatible.*"regulator-fixed"/ {
> > >> found = 1;
> > >> }
> > >>
> > >> /enable-active-high/ {
> > >> active_high = 1;
> > >> }
> > >>
> > >> /gpio-open-drain/ {
> > >> open_drain = 1;
> > >> }
> > >>
> > >> match($0, /gpio += <.* ([^ ]*)>/, ary) {
> > >> gpio = 1;
> > >> flags = ary[1];
> > >> if (flags == 0)
> > >> flags = "GPIO_ACTIVE_HIGH";
> > >> }
> > >>
> > >> /}/ {
> > >> if (found) {
> > >> if (gpio) {
> > >> print "\t" name ": active high " active_high " " flags " open
> drain "
> > >> open_drain;
> > >> if ((active_high && flags == "GPIO_ACTIVE_LOW") ||
> > >> (!active_high && flags == "GPIO_ACTIVE_HIGH"))
> > >> print "WARNING: enable-active-high and flags do not
> match"
> > >> } else {
> > >> if (active_high)
> > >> print "WARNING: active high without GPIO"
> > >> if (open_drain)
> > >> print "WARNING: open drain without GPIO"
> > >> }
> > >> }
> > >>
> > >> gpio = 0;
> > >> found = 0;
> > >> active_high = 0;
> > >> open_drain = 0;
> > >> flags = 0;
> > >> }
> > >> '
> > >> -------------------------------------------------------------------------
> > >>
> > >> All patches except for the ones touching omap3-beagle-xm and
> > >> omap3-overo-base are untested as I lack test hardware.
> > >>
> > >> As there's no dependency between the patches touching different source
> > >> files the appropriate maintainers could take their share of the patches
> > >> in their tree. Alternatively I could send a single pull request after
> > >> collecting all acks but that might be more complex.
> > >
> > > Nice clean-up. For omaps, there's an earlier patch posted by
> > > Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> as "[PATCH] ARM: dts:
> > > Use defined GPIO constants in flags cell for OMAP2+ boards". Can you guys
> > > do some cross checking and let me know which combination I should appluy
> > > for omaps?
> >
> > Since Laurent's changes for OMAP are part of a bigger series and my patch
> > was only for OMAP, probably makes sense for you to pick his patches and I
> > can re-spin mine on top of that.
> >
> > BTW, I posted as a single patch since the changes were trivial but maybe
> > that made handling these conflicts harder and I should split the changes
> > instead, since I'll resend anyways.
> >
> > What do you prefer? a patch per SoC family (i.e: OMAP{2,3,4,5}) or patch
> > per board DTS?
>
> My series will likely miss the next merge window as more discussion is needed.
> I'll thus respin the patches on top of yours, please proceed without caring
> about this.
OK applying Javier's patch into omap-for-v4.4/dt then.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
[not found] ` <1444684386-17094-1-git-send-email-laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2015-10-12 21:46 ` Tony Lindgren
@ 2015-10-13 6:19 ` Sascha Hauer
2015-10-13 14:09 ` Shawn Guo
2 siblings, 0 replies; 9+ messages in thread
From: Sascha Hauer @ 2015-10-13 6:19 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Andrew Lunn,
Krzysztof Kozlowski, Tony Lindgren, Linus Walleij, Liam Girdwood,
Gregory Clement, Thierry Reding, Alexandre Courbot,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Kukjin Kim,
Sebastian Hesselbarth, devicetree-u79uwXL29TY76Z2rM5mHXA,
Jason Cooper, Stephen Warren, linux-gpio-u79uwXL29TY76Z2rM5mHXA,
Mark Brown, linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, Sascha Hauer,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Benoit Cousson, Shawn Guo
On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> Hello,
>
> While working on regulators, GPIOs and DT I noticed that many of our DT source
> files incorrectly describe fixed regulators. The common error patterns are
>
> - Usage of the undefined (and never parsed) enable-active-low property
> - Usage of the enable-active-high property without specifying an enable GPIO
> - Typos in the enabl GPIO property name (gpios instead of gpio)
> - Mismatch between the enable-active-high property (or the lack thereof) and
> the enable GPIO flags
>
> This patch series fixes those issues in all the DT sources after locating the
> errors using the following script.
Nice. For the i.MX boards:
Reviewed-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
[not found] ` <1444684386-17094-1-git-send-email-laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2015-10-12 21:46 ` Tony Lindgren
2015-10-13 6:19 ` Sascha Hauer
@ 2015-10-13 14:09 ` Shawn Guo
2015-10-13 14:17 ` Laurent Pinchart
2 siblings, 1 reply; 9+ messages in thread
From: Shawn Guo @ 2015-10-13 14:09 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Benoit Cousson,
Tony Lindgren, Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Kukjin Kim, Krzysztof Kozlowski,
Sascha Hauer, Stephen Warren, Thierry Reding, Alexandre Courbot,
Liam Girdwood, Mark Brown, Linus Walleij
On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> Laurent Pinchart (37):
...
> ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
...
> ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
...
> ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
> ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
> ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
> ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
> ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
> ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
> ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
> ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
> ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
> ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
> ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
Applied these 15 patches, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-13 14:09 ` Shawn Guo
@ 2015-10-13 14:17 ` Laurent Pinchart
2015-10-13 15:09 ` Shawn Guo
0 siblings, 1 reply; 9+ messages in thread
From: Laurent Pinchart @ 2015-10-13 14:17 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, devicetree, linux-omap, linux-samsung-soc,
linux-tegra, linux-gpio, linux-kernel, Benoit Cousson,
Tony Lindgren, Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Kukjin Kim, Krzysztof Kozlowski,
Sascha Hauer, Stephen Warren, Thierry Reding, Alexandre Courbot,
Liam Girdwood, Mark Brown, Linus Walleij
Hi Shawn,
On Tuesday 13 October 2015 22:09:46 Shawn Guo wrote:
> On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> > Laurent Pinchart (37):
> ...
>
> > ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
>
> ...
>
> > ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
>
> ...
>
> > ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
> > ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
> > ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
> > ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
> > ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
> > ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
> > ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
>
> Applied these 15 patches, thanks.
There's ongoing discussions regarding whether this is the right thing to do.
Please see http://www.spinics.net/lists/arm-kernel/msg451724.html. It's thus a
bit early to apply the patches at this point I'm afraid.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity
2015-10-13 14:17 ` Laurent Pinchart
@ 2015-10-13 15:09 ` Shawn Guo
0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2015-10-13 15:09 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-arm-kernel, devicetree, linux-omap, linux-samsung-soc,
linux-tegra, linux-gpio, linux-kernel, Benoit Cousson,
Tony Lindgren, Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, Kukjin Kim, Krzysztof Kozlowski,
Sascha Hauer, Stephen Warren, Thierry Reding, Alexandre Courbot,
Liam Girdwood, Mark Brown, Linus Walleij
On Tue, Oct 13, 2015 at 05:17:24PM +0300, Laurent Pinchart wrote:
> Hi Shawn,
>
> On Tuesday 13 October 2015 22:09:46 Shawn Guo wrote:
> > On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote:
> > > Laurent Pinchart (37):
> > ...
> >
> > > ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property
> >
> > ...
> >
> > > ARM: dts: imx6qdl-tx6: Fix regulator enable GPIO polarity
> >
> > ...
> >
> > > ARM: dts: imx23-evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx23-stmp378x_devb: Fix regulator enable GPIO polarity
> > > ARM: dts: imx25-pdk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-cfa10036: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-m28cu3: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-m28evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-sps1: Fix regulator enable GPIO polarity
> > > ARM: dts: imx28-tx28: Fix regulator enable GPIO polarity
> > > ARM: dts: imx53-m53evk: Fix regulator enable GPIO polarity
> > > ARM: dts: imx53-mba53: Fix regulator enable GPIO polarity
> > > ARM: dts: imx53-tx53: Fix regulator enable GPIO polarity
> > > ARM: dts: imx6q-dmo-edmqmx6: Fix regulator enable GPIO polarity
> >
> > Applied these 15 patches, thanks.
>
> There's ongoing discussions regarding whether this is the right thing to do.
> Please see http://www.spinics.net/lists/arm-kernel/msg451724.html. It's thus a
> bit early to apply the patches at this point I'm afraid.
Okay, dropped them except the first one which fixes a typo for
imx6sx-sdb.
Shawn
^ permalink raw reply [flat|nested] 9+ messages in thread