From: Greg KH <gregkh@linuxfoundation.org>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: baytrail: Serialize all register access
Date: Fri, 30 Oct 2015 08:26:59 -0700 [thread overview]
Message-ID: <20151030152659.GA29070@kroah.com> (raw)
In-Reply-To: <CAKi4VAK0WcoP7CHZCrB=r_T=ywo8bcKt=_iA=Tb0mQR64HCoWw@mail.gmail.com>
On Fri, Oct 30, 2015 at 12:48:38PM -0200, Lucas De Marchi wrote:
> Hi Mika and Linus,
>
> CC'ing Greg.
>
> On Tue, Aug 4, 2015 at 9:03 AM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > There is a hardware issue in Intel Baytrail where concurrent GPIO register
> > access might result reads of 0xffffffff and writes might get dropped
> > completely.
> >
> > Prevent this from happening by taking the serializing lock in all places
> > where it is possible that more than one thread might be accessing the
> > hardware concurrently.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > ---
>
> Now that this is on 4.2, can we get it on stable branches? I was
> hitting this bug for some time on MinnowBoard Max and this week I had
> some time to take a look on how to fix it. Good timing, it had already
> been fixed. Applying this patch the issue is gone on top of 4.1.12.
>
> I'm using these patches from Linus Torvalds' tree:
> 39ce815 pinctrl: baytrail: Serialize all register access
> 78e1c89 pinctrl: baytrail: Use raw_spinlock for locking
>
>
> The ones to Cherryview could be sent too but I couldn't test them.
>
> Leaving the patch below for reference.
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2015-10-30 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 12:03 [PATCH 1/2] pinctrl: baytrail: Drop FSF mailing address Mika Westerberg
2015-08-04 12:03 ` [PATCH 2/2] pinctrl: baytrail: Serialize all register access Mika Westerberg
2015-08-13 12:26 ` Linus Walleij
2015-10-30 14:48 ` Lucas De Marchi
2015-10-30 15:26 ` Greg KH [this message]
2015-08-13 12:25 ` [PATCH 1/2] pinctrl: baytrail: Drop FSF mailing address Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030152659.GA29070@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=mathias.nyman@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).