From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH 1/2] pinctrl: uniphier: enable UniPhier SoCs pinctrl drivers by default Date: Sat, 31 Oct 2015 01:41:10 +0000 Message-ID: <20151031014110.GA1991@localhost> References: <1445912911-1292-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:35510 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbbJaCE5 (ORCPT ); Fri, 30 Oct 2015 22:04:57 -0400 Received: by pasz6 with SMTP id z6so89666200pas.2 for ; Fri, 30 Oct 2015 19:04:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Masahiro Yamada , "arm@kernel.org" , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" On Thu, Oct 29, 2015 at 02:33:34PM +0100, Linus Walleij wrote: > On Tue, Oct 27, 2015 at 3:28 AM, Masahiro Yamada > wrote: > > > Add "default y" to the Kconfig rather than adding entries into > > arch/arm/configs/multi_v7_defconfig. > > > > Signed-off-by: Masahiro Yamada > > (...) > > config PINCTRL_UNIPHIER_PH1_LD4 > > tristate "UniPhier PH1-LD4 SoC pinctrl driver" > > + default y > > select PINCTRL_UNIPHIER_CORE > > Why is it not default y if ? > > So it is only turned on if the corresponding SoC is selected? > > Or don't you have symbols like that? > > ARM SoC folks: can you ACK this patch indicating that this is the way > you wanna handle this? Most other will have a "default MACH_", but Uniphier lacks those Kconfig symbols. Or even a def_bool for that platform such that it's not an option if the platform is enabled. It makes no sense to enable a platform but not the pinctrl on it, so that's a good way to do it. I would honestly rather have those in the mach makefile, and make the drivers select the right thing by default, than having to know exactly which drivers to enable for a specific SoC. -Olof