From: Thierry Reding <thierry.reding@gmail.com>
To: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
Cc: linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
swarren@wwwdotorg.org, gnurou@gmail.com
Subject: Re: [PATCH] gpio-tegra: Do not create the debugfs entry by default
Date: Mon, 16 Nov 2015 17:49:01 +0100 [thread overview]
Message-ID: <20151116164901.GA21467@ulmo.nvidia.com> (raw)
In-Reply-To: <1447690030-26529-1-git-send-email-suzuki.poulose@arm.com>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
On Mon, Nov 16, 2015 at 04:07:10PM +0000, Suzuki K. Poulose wrote:
> The tegra gpio driver creates the debugfs entry irrespective of
> whether the device exists or not. This is enabled on an arm64_defconfig
> and leaves an entry in debugfs on all platforms where it is not
> useful. This patch fixes the issue by creating the entry only when
> a device exists.
>
> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
> ---
> drivers/gpio/gpio-tegra.c | 105 ++++++++++++++++++++++++---------------------
> 1 file changed, 56 insertions(+), 49 deletions(-)
Yikes, good catch!
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-11-16 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 16:07 [PATCH] gpio-tegra: Do not create the debugfs entry by default Suzuki K. Poulose
2015-11-16 16:49 ` Thierry Reding [this message]
2015-11-17 14:20 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116164901.GA21467@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).