From: Shawn Guo <shawnguo@kernel.org>
To: Liu Gang <Gang.Liu@freescale.com>
Cc: robh+dt@kernel.org, linus.walleij@linaro.org, arnd@arndb.de,
devicetree@vger.kernel.org, R58472@freescale.com,
b07421@freescale.com, bhupesh.sharma@freescale.com,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ls2080a/dts: Add little endian property for GPIO IP block
Date: Tue, 24 Nov 2015 14:57:32 +0800 [thread overview]
Message-ID: <20151124065732.GM11999@tiger> (raw)
In-Reply-To: <1446619704-27669-1-git-send-email-Gang.Liu@freescale.com>
On Wed, Nov 04, 2015 at 02:48:23PM +0800, Liu Gang wrote:
> The GPIO block for ls2080a platform has little endian registers,
> the GPIO driver needs this property to read/write registers by
> right interface.
>
> Signed-off-by: Liu Gang <Gang.Liu@freescale.com>
Please do not mix binding doc together with dts changes in one patch.
Shawn
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-mpc8xxx.txt b/Documentation/devicetree/bindings/gpio/gpio-mpc8xxx.txt
> index f2455c5..c836dab 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-mpc8xxx.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-mpc8xxx.txt
> @@ -10,6 +10,9 @@ Required properties:
> the second cell is used to specify the gpio polarity:
> 0 = active high
> 1 = active low
> +- little-endian : Should be set if the GPIO has little endian
> + registers. No the property means the GPIO
> + registers are big endian mode.
>
> Example:
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> index f3c59f9..41bb8c1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> @@ -277,6 +277,7 @@
> reg = <0x0 0x2300000 0x0 0x10000>;
> interrupts = <0 36 0x4>; /* Level high type */
> gpio-controller;
> + little-endian;
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -287,6 +288,7 @@
> reg = <0x0 0x2310000 0x0 0x10000>;
> interrupts = <0 36 0x4>; /* Level high type */
> gpio-controller;
> + little-endian;
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -297,6 +299,7 @@
> reg = <0x0 0x2320000 0x0 0x10000>;
> interrupts = <0 37 0x4>; /* Level high type */
> gpio-controller;
> + little-endian;
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> @@ -307,6 +310,7 @@
> reg = <0x0 0x2330000 0x0 0x10000>;
> interrupts = <0 37 0x4>; /* Level high type */
> gpio-controller;
> + little-endian;
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> --
> 2.1.0.27.g96db324
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2015-11-24 6:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 6:48 [PATCH 1/2] ls2080a/dts: Add little endian property for GPIO IP block Liu Gang
2015-11-04 6:48 ` [PATCH 2/2] drivers/gpio: Port gpio driver to layerscape platform Liu Gang
2015-11-04 8:53 ` Arnd Bergmann
2015-11-04 9:17 ` Scott Wood
2015-11-04 10:09 ` Arnd Bergmann
2015-11-05 13:27 ` [PATCH 1/2] ls2080a/dts: Add little endian property for GPIO IP block Rob Herring
2015-11-24 6:57 ` Shawn Guo [this message]
[not found] <1446549552-40675-1-git-send-email-Gang.Liu@freescale.com>
2015-11-16 15:11 ` Linus Walleij
2015-11-16 18:56 ` Li Yang
[not found] ` <CADRPPNROHmnOHfpAtaii5Hr3hzUmn4BL5OpQ4Q4hr9BGLq8s0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-16 19:12 ` Scott Wood
2015-11-17 14:36 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124065732.GM11999@tiger \
--to=shawnguo@kernel.org \
--cc=Gang.Liu@freescale.com \
--cc=R58472@freescale.com \
--cc=arnd@arndb.de \
--cc=b07421@freescale.com \
--cc=bhupesh.sharma@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).