From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Johan Hovold <johan@kernel.org>,
"Tirdea, Irina" <irina.tirdea@intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] gpiolib: tighten up ACPI legacy gpio lookups
Date: Fri, 27 Nov 2015 09:37:21 -0800 [thread overview]
Message-ID: <20151127173721.GC27040@dtor-ws> (raw)
In-Reply-To: <CACRpkdbXaXzQ38sy9JJGEhx+ix3WzheAsKJqsXum2T9n00YEvA@mail.gmail.com>
On Tue, Nov 17, 2015 at 02:43:14PM +0100, Linus Walleij wrote:
> On Wed, Nov 11, 2015 at 8:45 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>
> > We should not fall back to the legacy unnamed gpio lookup style if the
> > driver requests gpios with different names, because we'll give out the same
> > gpio twice. Let's keep track of the names that were used for the device and
> > only do the fallback for the first name used.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> >
> > v1: incorporated changes suggested by Mika Westerberg in response to the
> > draft patch I posted in Goodix thread.
> >
> > v2: moved acpi_can_fallback_to_crs body to drivers/gpio/gpiolib-acpi.c
> > and provided stub for !CONFIG_ACPI case to fix build error if ACPI is
> > disabled.
>
> Patch applied with Mika's ACK.
>
> Had to fuzz a bit to make it apply, hope nothing breaks.
Hmm, I'd like to get this patch into my tree as well to apply Irina's
goodix pieces on top to make sure they do not break. Would it be OK for
me to just apply the patch and hope git will sort it out when we merge
into next/mainline, you maybe you could prepare a 4.3-based branch with
the patch for me to pull?
Thanks!
--
Dmitry
next prev parent reply other threads:[~2015-11-27 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 19:45 [PATCH v2] gpiolib: tighten up ACPI legacy gpio lookups Dmitry Torokhov
2015-11-12 9:02 ` Mika Westerberg
2015-11-17 13:43 ` Linus Walleij
2015-11-27 17:37 ` Dmitry Torokhov [this message]
2015-12-09 15:11 ` Linus Walleij
2015-12-09 17:21 ` Dmitry Torokhov
2015-12-13 16:37 ` Linus Walleij
2015-12-13 16:44 ` Dmitry Torokhov
2015-12-15 13:24 ` Linus Walleij
2015-12-15 18:47 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151127173721.GC27040@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=gnurou@gmail.com \
--cc=irina.tirdea@intel.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).