From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Date: Thu, 3 Dec 2015 13:37:15 -0800 Message-ID: <20151203213715.GA23396@atomide.com> References: <1448644860-29323-1-git-send-email-sudeep.holla@arm.com> <1448644860-29323-2-git-send-email-sudeep.holla@arm.com> <20151203181337.GV23396@atomide.com> <56608B72.1040101@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56608B72.1040101@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Grygorii Strashko Cc: Linus Walleij , Sudeep Holla , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-omap@vger.kernel.org List-Id: linux-gpio@vger.kernel.org * Grygorii Strashko [151203 10:36]: > > I think, this patch should not break our wake-up functionality. > It will just change the moment when pcs_irq_handler() will be called: > > before this change: > - suspend_enter() > .... > - arch_suspend_enable_irqs(); > - ^ right here > > after this change: > - suspend_enter() > .... > dpm_resume_noirq() > - resume_device_irqs() > ^ here > > Correct? And as for me this is more safe. I think there's more to it though. With both applied, it produces this on coming back up from suspend: PM: noirq resume of devices complete after 18.127 msecs ------------[ cut here ]------------ WARNING: CPU: 0 PID: 123 at kernel/irq/manage.c:605 irq_set_irq_wake+0xbc/0xfc() Unbalanced IRQ 375 wake disable Modules linked in: ledtrig_default_on leds_gpio led_class rtc_twl twl4030_wdt CPU: 0 PID: 123 Comm: bash Tainted: G W 4.4.0-rc3-dirty #2682 Hardware name: Generic OMAP36xx (Flattened Device Tree) [] (unwind_backtrace) from [] (show_stack+0x10/0x14) ] (show_stack) from [] (dump_stack+0x84/0x9c) [] (dump_stack) from [] (warn_slowpath_common+0x7c/0xb8) [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40) [] (warn_slowpath_fmt) from [] (irq_set_irq_wake+0xbc/0xfc) [] (irq_set_irq_wake) from [] (device_wakeup_disarm_wake_irqs+0x70/0x12c) [] (device_wakeup_disarm_wake_irqs) from [] (dpm_resume_noirq+0x20c/0x2e4) [] (dpm_resume_noirq) from [] (suspend_devices_and_enter+0x1e4/0x6bc) [] (suspend_devices_and_enter) from [] (pm_suspend+0x358/0x4b8) [] (pm_suspend) from [] (state_store+0x64/0xb8) [] (state_store) from [] (kobj_attr_store+0x14/0x20) [] (kobj_attr_store) from [] (sysfs_kf_write+0x4c/0x50) [] (sysfs_kf_write) from [] (kernfs_fop_write+0xbc/0x1cc) [] (kernfs_fop_write) from [] (__vfs_write+0x24/0xd8) [] (__vfs_write) from [] (vfs_write+0x94/0x154) [] (vfs_write) from [] (SyS_write+0x40/0x94) [] (SyS_write) from [] (ret_fast_syscall+0x0/0x1c) ---[ end trace 321b51565e161bee ]--- And these both need to be applied together when we have a fix for the above as otherwise we'll get the lock recursion Sudeep mentioned in patch 2/2. Regards, Tony