From: Alban <albeu@free.fr>
To: Axel Lin <axel.lin@ingics.com>
Cc: Alban <albeu@free.fr>, Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH RFT] gpio: ath79: Fix the logic to clear offset bit of AR71XX_GPIO_REG_OE register
Date: Wed, 9 Dec 2015 11:19:15 +0100 [thread overview]
Message-ID: <20151209111915.786d9dcf@avionic-0020> (raw)
In-Reply-To: <1449586867.5555.1.camel@ingics.com>
On Tue, 08 Dec 2015 23:01:07 +0800
Axel Lin <axel.lin@ingics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Alban Bedel <albeu@free.fr>
> ---
> drivers/gpio/gpio-ath79.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index e5827a5..5eaea8b 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -113,7 +113,7 @@ static int ar934x_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
> __raw_writel(BIT(offset), ctrl->base + AR71XX_GPIO_REG_CLEAR);
>
> __raw_writel(
> - __raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & BIT(offset),
> + __raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & ~BIT(offset),
> ctrl->base + AR71XX_GPIO_REG_OE);
>
> spin_unlock_irqrestore(&ctrl->lock, flags);
next prev parent reply other threads:[~2015-12-09 10:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 15:01 [PATCH RFT] gpio: ath79: Fix the logic to clear offset bit of AR71XX_GPIO_REG_OE register Axel Lin
2015-12-09 10:19 ` Alban [this message]
2015-12-11 18:13 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209111915.786d9dcf@avionic-0020 \
--to=albeu@free.fr \
--cc=axel.lin@ingics.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).