From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Michael Welling <mwelling@ieee.org>,
Markus Pargmann <mpa@pengutronix.de>,
Anton Vorontsov <anton@enomsg.org>,
arm@kernel.org, Lee Jones <lee.jones@linaro.org>,
Alexander Shiyan <shc_work@mail.ru>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Alexandre Courbot <gnurou@gmail.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Olof Johansson <olof@lixom.net>,
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
Rabin Vincent <rab>
Subject: Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct
Date: Wed, 9 Dec 2015 11:49:50 -0800 [thread overview]
Message-ID: <20151209194950.GA23396@atomide.com> (raw)
In-Reply-To: <1449666760-29876-1-git-send-email-linus.walleij@linaro.org>
* Linus Walleij <linus.walleij@linaro.org> [151209 05:14]:
> The separate struct bgpio_chip has been a pain to handle, both
> by being confusingly similar in name to struct gpio_chip and
> for being contained inside a struct so that struct gpio_chip
> is contained in a struct contained in a struct, making several
> steps of dereferencing necessary.
>
> Make things simpler: include the fields directly into
> <linux/gpio/driver.h>, #ifdef:ed for CONFIG_GENERIC_GPIO, and
> get rid of the <linux/basic_mmio_gpio.h> altogether. Prefix
> some of the member variables with bgpio_* and add proper
> kerneldoc while we're at it.
>
> Modify all users to handle the change and use a struct
> gpio_chip directly. And while we're at it: replace all
> container_of() dereferencing by gpiochip_get_data() and
> registering the gpio_chip with gpiochip_add_data().
...
> ---
> ARM SoC folks and Lee: it would be great if you could
> ACK the few lines hitting arch/arm/* and drivers/mfd/* in this
> so I can take it through the GPIO tree.
For omap:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2015-12-09 19:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:12 [PATCH 004/182] gpio: generic: factor into gpio_chip struct Linus Walleij
2015-12-09 15:45 ` Liviu Dudau
2015-12-09 18:10 ` Hartley Sweeten
2015-12-09 19:49 ` Tony Lindgren [this message]
2015-12-09 23:08 ` Michael Welling
2015-12-13 20:15 ` Linus Walleij
2015-12-10 2:19 ` Krzysztof Kozlowski
2015-12-10 8:06 ` Lee Jones
2015-12-14 2:35 ` Gregory Fong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209194950.GA23396@atomide.com \
--to=tony@atomide.com \
--cc=acourbot@nvidia.com \
--cc=anton@enomsg.org \
--cc=arm@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gnurou@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=johan@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
--cc=nicolas.pitre@linaro.org \
--cc=olof@lixom.net \
--cc=shawnguo@kernel.org \
--cc=shc_work@mail.ru \
--cc=sudeep.holla@arm.com \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).