Re: [PATCH 056/182] gpio: samsung: use gpiochip data pointer

[Michael Welling <mwelling@ieee.org>]

On Wed, Dec 09, 2015 at 02:22:22PM +0100, Linus Walleij wrote:
> This makes the driver use the data pointer added to the gpio_chip
> to store a pointer to the state container instead of relying on
> container_of().
> 
> Cc: Paul Bolle <pebolle@tiscali.nl>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/gpio/gpio-samsung.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 7c288ba4dc87..4cb4a314c02b 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -753,7 +753,7 @@ static void __init samsung_gpiolib_add(struct samsung_gpio_chip *chip)
>  #endif
>  

gpiochip_add is still mentioned in the comments instead of gpiochip_add_data.
Both here and in the comment block above this function.

>  	/* gpiochip_add() prints own failure message on error. */
> -	ret = gpiochip_add(gc);
> +	ret = gpiochip_add_data(gc, chip);
>  	if (ret >= 0)
>  		s3c_gpiolib_track(chip);
>  }
> @@ -862,7 +862,7 @@ static void __init samsung_gpiolib_add_4bit2_chips(struct samsung_gpio_chip *chi
>  
>  int samsung_gpiolib_to_irq(struct gpio_chip *chip, unsigned int offset)
>  {
> -	struct samsung_gpio_chip *samsung_chip = container_of(chip, struct samsung_gpio_chip, chip);
> +	struct samsung_gpio_chip *samsung_chip = gpiochip_get_data(chip);
>  
>  	return samsung_chip->irq_base + offset;
>  }
> -- 
> 2.4.3
>