From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Michael Welling <mwelling@ieee.org>,
Markus Pargmann <mpa@pengutronix.de>,
Paul Parsons <lost.distance@yahoo.com>
Subject: Re: [PATCH 161/182] mfd: asic3: use gpiochip data pointer
Date: Thu, 10 Dec 2015 10:37:04 +0000 [thread overview]
Message-ID: <20151210103704.GA13538@x1> (raw)
In-Reply-To: <1449668842-6166-1-git-send-email-linus.walleij@linaro.org>
On Wed, 09 Dec 2015, Linus Walleij wrote:
> This makes the driver use the data pointer added to the gpio_chip
> to store a pointer to the state container instead of relying on
> container_of().
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Paul Parsons <lost.distance@yahoo.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Lee please ACK this so I can take it through the GPIO tree.
>
> I want to try to optimistically merge these changes without any
> immutable branches, as I suspect other subsystem maintainers might
> not want to pull a branch with 200+ patches into each subsystem,
> but let's see what happens.
> ---
> drivers/mfd/asic3.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> index a726f01e3b02..013ba51de819 100644
> --- a/drivers/mfd/asic3.c
> +++ b/drivers/mfd/asic3.c
> @@ -447,7 +447,7 @@ static int asic3_gpio_direction(struct gpio_chip *chip,
> unsigned long flags;
> struct asic3 *asic;
>
> - asic = container_of(chip, struct asic3, gpio);
> + asic = gpiochip_get_data(chip);
> gpio_base = ASIC3_GPIO_TO_BASE(offset);
>
> if (gpio_base > ASIC3_GPIO_D_BASE) {
> @@ -493,7 +493,7 @@ static int asic3_gpio_get(struct gpio_chip *chip,
> u32 mask = ASIC3_GPIO_TO_MASK(offset);
> struct asic3 *asic;
>
> - asic = container_of(chip, struct asic3, gpio);
> + asic = gpiochip_get_data(chip);
> gpio_base = ASIC3_GPIO_TO_BASE(offset);
>
> if (gpio_base > ASIC3_GPIO_D_BASE) {
> @@ -513,7 +513,7 @@ static void asic3_gpio_set(struct gpio_chip *chip,
> unsigned long flags;
> struct asic3 *asic;
>
> - asic = container_of(chip, struct asic3, gpio);
> + asic = gpiochip_get_data(chip);
> gpio_base = ASIC3_GPIO_TO_BASE(offset);
>
> if (gpio_base > ASIC3_GPIO_D_BASE) {
> @@ -542,7 +542,7 @@ static void asic3_gpio_set(struct gpio_chip *chip,
>
> static int asic3_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
> {
> - struct asic3 *asic = container_of(chip, struct asic3, gpio);
> + struct asic3 *asic = gpiochip_get_data(chip);
>
> return asic->irq_base + offset;
> }
> @@ -597,7 +597,7 @@ static __init int asic3_gpio_probe(struct platform_device *pdev,
> alt_reg[i]);
> }
>
> - return gpiochip_add(&asic->gpio);
> + return gpiochip_add_data(&asic->gpio, asic);
> }
>
> static int asic3_gpio_remove(struct platform_device *pdev)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-12-10 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:47 [PATCH 161/182] mfd: asic3: use gpiochip data pointer Linus Walleij
2015-12-10 10:37 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210103704.GA13538@x1 \
--to=lee.jones@linaro.org \
--cc=acourbot@nvidia.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=lost.distance@yahoo.com \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).