From: Jean Delvare <jdelvare@suse.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Michael Welling <mwelling@ieee.org>,
Markus Pargmann <mpa@pengutronix.de>,
Thierry Reding <treding@nvidia.com>,
Daniel Krueger <daniel.krueger@systec-electronic.com>
Subject: Re: [PATCH 050/182] gpio: pch: use gpiochip data pointer
Date: Mon, 14 Dec 2015 13:07:09 +0100 [thread overview]
Message-ID: <20151214130709.7d0e5e75@endymion.delvare> (raw)
In-Reply-To: <1449667188-32127-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
On Wed, 9 Dec 2015 14:19:48 +0100, Linus Walleij wrote:
> This makes the driver use the data pointer added to the gpio_chip
> to store a pointer to the state container instead of relying on
> container_of().
>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>
> Cc: Jean Delvare <jdelvare@suse.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-pch.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
> index e43db64e52b3..9349351afb47 100644
> --- a/drivers/gpio/gpio-pch.c
> +++ b/drivers/gpio/gpio-pch.c
> @@ -109,7 +109,7 @@ struct pch_gpio {
> static void pch_gpio_set(struct gpio_chip *gpio, unsigned nr, int val)
> {
> u32 reg_val;
> - struct pch_gpio *chip = container_of(gpio, struct pch_gpio, gpio);
> + struct pch_gpio *chip = gpiochip_get_data(gpio);
> unsigned long flags;
>
> spin_lock_irqsave(&chip->spinlock, flags);
> @@ -125,7 +125,7 @@ static void pch_gpio_set(struct gpio_chip *gpio, unsigned nr, int val)
>
> static int pch_gpio_get(struct gpio_chip *gpio, unsigned nr)
> {
> - struct pch_gpio *chip = container_of(gpio, struct pch_gpio, gpio);
> + struct pch_gpio *chip = gpiochip_get_data(gpio);
>
> return ioread32(&chip->reg->pi) & (1 << nr);
> }
> @@ -133,7 +133,7 @@ static int pch_gpio_get(struct gpio_chip *gpio, unsigned nr)
> static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned nr,
> int val)
> {
> - struct pch_gpio *chip = container_of(gpio, struct pch_gpio, gpio);
> + struct pch_gpio *chip = gpiochip_get_data(gpio);
> u32 pm;
> u32 reg_val;
> unsigned long flags;
> @@ -158,7 +158,7 @@ static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned nr,
>
> static int pch_gpio_direction_input(struct gpio_chip *gpio, unsigned nr)
> {
> - struct pch_gpio *chip = container_of(gpio, struct pch_gpio, gpio);
> + struct pch_gpio *chip = gpiochip_get_data(gpio);
> u32 pm;
> unsigned long flags;
>
> @@ -211,7 +211,7 @@ static void pch_gpio_restore_reg_conf(struct pch_gpio *chip)
>
> static int pch_gpio_to_irq(struct gpio_chip *gpio, unsigned offset)
> {
> - struct pch_gpio *chip = container_of(gpio, struct pch_gpio, gpio);
> + struct pch_gpio *chip = gpiochip_get_data(gpio);
> return chip->irq_base + offset;
> }
>
> @@ -394,7 +394,7 @@ static int pch_gpio_probe(struct pci_dev *pdev,
> pci_set_drvdata(pdev, chip);
> spin_lock_init(&chip->spinlock);
> pch_gpio_setup(chip);
> - ret = gpiochip_add(&chip->gpio);
> + ret = gpiochip_add_data(&chip->gpio, chip);
> if (ret) {
> dev_err(&pdev->dev, "PCH gpio: Failed to register GPIO\n");
> goto err_gpiochip_add;
Looks good, although I can't test it without patches 001 and 002, which
were not sent to me and are only archived by the download-unfriendly
gmane.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2015-12-14 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:19 [PATCH 050/182] gpio: pch: use gpiochip data pointer Linus Walleij
2015-12-14 12:07 ` Jean Delvare [this message]
2015-12-15 13:02 ` Linus Walleij
2016-01-04 8:55 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214130709.7d0e5e75@endymion.delvare \
--to=jdelvare@suse.de \
--cc=acourbot@nvidia.com \
--cc=daniel.krueger@systec-electronic.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).