From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Michael Hennerich <michael.hennerich@analog.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Michael Welling <mwelling@ieee.org>,
Markus Pargmann <mpa@pengutronix.de>
Subject: Re: [PATCH 157/182] input: ad7879: use gpiochip data pointer
Date: Wed, 16 Dec 2015 14:08:39 -0800 [thread overview]
Message-ID: <20151216220839.GD10962@dtor-ws> (raw)
In-Reply-To: <5668300F.8070800@analog.com>
On Wed, Dec 09, 2015 at 02:43:43PM +0100, Michael Hennerich wrote:
> On 12/09/2015 02:45 PM, Linus Walleij wrote:
> >This makes the driver use the data pointer added to the gpio_chip
> >to store a pointer to the state container instead of relying on
> >container_of().
> >
> >Cc: Michael Hennerich <michael.hennerich@analog.com>
> >Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Acked-by: Michael Hennerich <michael.hennerich@analog.com>
>
> >---
> >Dmitry: please ACK this so I can take it through the GPIO tree.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >---
> > drivers/input/touchscreen/ad7879.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> >diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c
> >index 16b5cc2196f2..583a0590ceb2 100644
> >--- a/drivers/input/touchscreen/ad7879.c
> >+++ b/drivers/input/touchscreen/ad7879.c
> >@@ -379,7 +379,7 @@ static const struct attribute_group ad7879_attr_group = {
> > static int ad7879_gpio_direction_input(struct gpio_chip *chip,
> > unsigned gpio)
> > {
> >- struct ad7879 *ts = container_of(chip, struct ad7879, gc);
> >+ struct ad7879 *ts = gpiochip_get_data(chip);
> > int err;
> >
> > mutex_lock(&ts->mutex);
> >@@ -393,7 +393,7 @@ static int ad7879_gpio_direction_input(struct gpio_chip *chip,
> > static int ad7879_gpio_direction_output(struct gpio_chip *chip,
> > unsigned gpio, int level)
> > {
> >- struct ad7879 *ts = container_of(chip, struct ad7879, gc);
> >+ struct ad7879 *ts = gpiochip_get_data(chip);
> > int err;
> >
> > mutex_lock(&ts->mutex);
> >@@ -412,7 +412,7 @@ static int ad7879_gpio_direction_output(struct gpio_chip *chip,
> >
> > static int ad7879_gpio_get_value(struct gpio_chip *chip, unsigned gpio)
> > {
> >- struct ad7879 *ts = container_of(chip, struct ad7879, gc);
> >+ struct ad7879 *ts = gpiochip_get_data(chip);
> > u16 val;
> >
> > mutex_lock(&ts->mutex);
> >@@ -425,7 +425,7 @@ static int ad7879_gpio_get_value(struct gpio_chip *chip, unsigned gpio)
> > static void ad7879_gpio_set_value(struct gpio_chip *chip,
> > unsigned gpio, int value)
> > {
> >- struct ad7879 *ts = container_of(chip, struct ad7879, gc);
> >+ struct ad7879 *ts = gpiochip_get_data(chip);
> >
> > mutex_lock(&ts->mutex);
> > if (value)
> >@@ -456,7 +456,7 @@ static int ad7879_gpio_add(struct ad7879 *ts,
> > ts->gc.owner = THIS_MODULE;
> > ts->gc.parent = ts->dev;
> >
> >- ret = gpiochip_add(&ts->gc);
> >+ ret = gpiochip_add_data(&ts->gc, ts);
> > if (ret)
> > dev_err(ts->dev, "failed to register gpio %d\n",
> > ts->gc.base);
> >
>
>
> --
> Greetings,
> Michael
>
> --
> Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
> Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
> Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
> Margaret Seif
--
Dmitry
prev parent reply other threads:[~2015-12-16 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:45 [PATCH 157/182] input: ad7879: use gpiochip data pointer Linus Walleij
2015-12-09 13:43 ` Michael Hennerich
2015-12-16 22:08 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151216220839.GD10962@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=acourbot@nvidia.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).