From: Bjorn Andersson <bjorn@kryo.se>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
"Ivan T. Ivanov" <ivan.ivanov@linaro.org>,
Bj?rn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [PATCH 27/54] pinctrl: spmi-gpio: Be sure to clamp return value
Date: Sun, 27 Dec 2015 19:52:54 -0800 [thread overview]
Message-ID: <20151228035254.GC16437@tuxbot> (raw)
In-Reply-To: <1450794638-23834-1-git-send-email-linus.walleij@linaro.org>
On Tue 22 Dec 06:30 PST 2015, Linus Walleij wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
>
> Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> Cc: Björn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
out_value is a bool, so the patch shouldn't be necessary. But I like
that it's consistent throughout.
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
On a separate note, I'm not sure that it's correct to update the cached
output value with the current input state here. Need to think a little
bit more on that.
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 3e5ccc76d59c..4460b2c9c8bd 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -533,7 +533,7 @@ static int pmic_gpio_get(struct gpio_chip *chip, unsigned pin)
> pad->out_value = ret & PMIC_MPP_REG_RT_STS_VAL_MASK;
> }
>
> - return pad->out_value;
> + return !!pad->out_value;
> }
>
> static void pmic_gpio_set(struct gpio_chip *chip, unsigned pin, int value)
> --
> 2.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-12-28 3:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 14:30 [PATCH 27/54] pinctrl: spmi-gpio: Be sure to clamp return value Linus Walleij
2015-12-28 3:52 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151228035254.GC16437@tuxbot \
--to=bjorn@kryo.se \
--cc=bjorn.andersson@sonymobile.com \
--cc=ivan.ivanov@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).