linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn@kryo.se>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
	"Ivan T. Ivanov" <ivan.ivanov@linaro.org>,
	Bj?rn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [PATCH 30/54] gpio: ssbi-mpp: Be sure to clamp return value
Date: Sun, 27 Dec 2015 20:01:15 -0800	[thread overview]
Message-ID: <20151228040115.GF16437@tuxbot> (raw)
In-Reply-To: <1450794693-24019-1-git-send-email-linus.walleij@linaro.org>

On Tue 22 Dec 06:31 PST 2015, Linus Walleij wrote:

> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
> 
> This code was also double-inverting a bool which makes no sense
> so I removed that code and moved clamping toward the end.
> 
> Cc: Björn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
> index 8f5c96cbf94e..23089d541230 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-mpp.c
> @@ -502,13 +502,13 @@ static int pm8xxx_mpp_get(struct gpio_chip *chip, unsigned offset)
>  	int ret;
>  
>  	if (!pin->input)
> -		return pin->output_value;
> +		return !!pin->output_value;

Per my answer on the gpio driver, you have my Reviewed-by on this piece.

>  
>  	ret = irq_get_irqchip_state(pin->irq, IRQCHIP_STATE_LINE_LEVEL, &state);
>  	if (!ret)
> -		ret = !!state;
> +		ret = state;
>  
> -	return ret;
> +	return !!ret;

But not on these two.

Regards,
Bjorn

>  }
>  
>  static void pm8xxx_mpp_set(struct gpio_chip *chip, unsigned offset, int value)
> -- 
> 2.4.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2015-12-28  4:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-22 14:31 [PATCH 30/54] gpio: ssbi-mpp: Be sure to clamp return value Linus Walleij
2015-12-28  4:01 ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151228040115.GF16437@tuxbot \
    --to=bjorn@kryo.se \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=ivan.ivanov@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).