linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 46/54] mfd: dm355evm_mps: Be sure to clamp return value
@ 2015-12-22 14:47 Linus Walleij
  2016-01-11  7:47 ` Lee Jones
  0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2015-12-22 14:47 UTC (permalink / raw)
  To: linux-gpio, Lee Jones; +Cc: Linus Walleij

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Lee: as mentioned in 00/54: either apply this directly
or ACK it and I will take it into the GPIO tree.
---
 drivers/mfd/dm355evm_msp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c
index bc90efe01b59..ec4438ed2faf 100644
--- a/drivers/mfd/dm355evm_msp.c
+++ b/drivers/mfd/dm355evm_msp.c
@@ -147,7 +147,7 @@ static int msp_gpio_get(struct gpio_chip *chip, unsigned offset)
 		return status;
 	if (reg == DM355EVM_MSP_LED)
 		msp_led_cache = status;
-	return status & MSP_GPIO_MASK(offset);
+	return !!(status & MSP_GPIO_MASK(offset));
 }
 
 static int msp_gpio_out(struct gpio_chip *chip, unsigned offset, int value)
-- 
2.4.3


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 46/54] mfd: dm355evm_mps: Be sure to clamp return value
@ 2015-12-22 14:47 Linus Walleij
  2016-01-11  7:47 ` Lee Jones
  0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2015-12-22 14:47 UTC (permalink / raw)
  To: linux-gpio, Lee Jones; +Cc: Linus Walleij

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Lee: as mentioned in 00/54: either apply this directly
or ACK it and I will take it into the GPIO tree.
---
 drivers/mfd/dm355evm_msp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c
index bc90efe01b59..ec4438ed2faf 100644
--- a/drivers/mfd/dm355evm_msp.c
+++ b/drivers/mfd/dm355evm_msp.c
@@ -147,7 +147,7 @@ static int msp_gpio_get(struct gpio_chip *chip, unsigned offset)
 		return status;
 	if (reg == DM355EVM_MSP_LED)
 		msp_led_cache = status;
-	return status & MSP_GPIO_MASK(offset);
+	return !!(status & MSP_GPIO_MASK(offset));
 }
 
 static int msp_gpio_out(struct gpio_chip *chip, unsigned offset, int value)
-- 
2.4.3


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 46/54] mfd: dm355evm_mps: Be sure to clamp return value
@ 2015-12-22 14:45 Linus Walleij
  2016-01-11  7:47 ` Lee Jones
  0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2015-12-22 14:45 UTC (permalink / raw)
  To: linux-gpio, Guan Xuetao; +Cc: Linus Walleij, Lee Jones

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Lee: as mentioned in 00/54: either apply this directly
or ACK it and I will take it into the GPIO tree.
---
 drivers/mfd/dm355evm_msp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c
index bc90efe01b59..ec4438ed2faf 100644
--- a/drivers/mfd/dm355evm_msp.c
+++ b/drivers/mfd/dm355evm_msp.c
@@ -147,7 +147,7 @@ static int msp_gpio_get(struct gpio_chip *chip, unsigned offset)
 		return status;
 	if (reg == DM355EVM_MSP_LED)
 		msp_led_cache = status;
-	return status & MSP_GPIO_MASK(offset);
+	return !!(status & MSP_GPIO_MASK(offset));
 }
 
 static int msp_gpio_out(struct gpio_chip *chip, unsigned offset, int value)
-- 
2.4.3


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-01-11  7:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-22 14:47 [PATCH 46/54] mfd: dm355evm_mps: Be sure to clamp return value Linus Walleij
2016-01-11  7:47 ` Lee Jones
  -- strict thread matches above, loose matches on Subject: below --
2015-12-22 14:47 Linus Walleij
2016-01-11  7:47 ` Lee Jones
2015-12-22 14:45 Linus Walleij
2016-01-11  7:47 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).