* [PATCH 45/54] mfd: asic3: Be sure to clamp return value
@ 2015-12-22 14:45 Linus Walleij
2016-01-11 7:48 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2015-12-22 14:45 UTC (permalink / raw)
To: linux-gpio, Guan Xuetao; +Cc: Linus Walleij, Paul Parsons, Lee Jones
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Paul Parsons <lost.distance@yahoo.com>
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Lee: as mentioned in 00/54: either apply this directly
or ACK it and I will take it into the GPIO tree.
---
drivers/mfd/asic3.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index a726f01e3b02..58c4d9cb8e8d 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -502,7 +502,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
return -EINVAL;
}
- return asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS) & mask;
+ return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS)
+ & mask));
}
static void asic3_gpio_set(struct gpio_chip *chip,
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 45/54] mfd: asic3: Be sure to clamp return value
@ 2015-12-22 14:47 Linus Walleij
2016-01-11 7:47 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2015-12-22 14:47 UTC (permalink / raw)
To: linux-gpio, Lee Jones; +Cc: Linus Walleij, Paul Parsons
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Paul Parsons <lost.distance@yahoo.com>
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Lee: as mentioned in 00/54: either apply this directly
or ACK it and I will take it into the GPIO tree.
---
drivers/mfd/asic3.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index a726f01e3b02..58c4d9cb8e8d 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -502,7 +502,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
return -EINVAL;
}
- return asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS) & mask;
+ return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS)
+ & mask));
}
static void asic3_gpio_set(struct gpio_chip *chip,
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 45/54] mfd: asic3: Be sure to clamp return value
2015-12-22 14:47 [PATCH 45/54] mfd: asic3: Be sure to clamp return value Linus Walleij
@ 2016-01-11 7:47 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2016-01-11 7:47 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, Paul Parsons
On Tue, 22 Dec 2015, Linus Walleij wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
>
> Cc: Paul Parsons <lost.distance@yahoo.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Lee: as mentioned in 00/54: either apply this directly
> or ACK it and I will take it into the GPIO tree.
> ---
> drivers/mfd/asic3.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> index a726f01e3b02..58c4d9cb8e8d 100644
> --- a/drivers/mfd/asic3.c
> +++ b/drivers/mfd/asic3.c
> @@ -502,7 +502,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
> return -EINVAL;
> }
>
> - return asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS) & mask;
> + return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS)
> + & mask));
> }
>
> static void asic3_gpio_set(struct gpio_chip *chip,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 45/54] mfd: asic3: Be sure to clamp return value
2015-12-22 14:45 Linus Walleij
@ 2016-01-11 7:48 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2016-01-11 7:48 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, Guan Xuetao, Paul Parsons
On Tue, 22 Dec 2015, Linus Walleij wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
>
> Cc: Paul Parsons <lost.distance@yahoo.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Lee: as mentioned in 00/54: either apply this directly
> or ACK it and I will take it into the GPIO tree.
> ---
> drivers/mfd/asic3.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> index a726f01e3b02..58c4d9cb8e8d 100644
> --- a/drivers/mfd/asic3.c
> +++ b/drivers/mfd/asic3.c
> @@ -502,7 +502,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
> return -EINVAL;
> }
>
> - return asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS) & mask;
> + return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS)
> + & mask));
> }
>
> static void asic3_gpio_set(struct gpio_chip *chip,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-11 7:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-22 14:47 [PATCH 45/54] mfd: asic3: Be sure to clamp return value Linus Walleij
2016-01-11 7:47 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2015-12-22 14:45 Linus Walleij
2016-01-11 7:48 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).