* [PATCH] gpio: max77620: fix of_table.cocci warnings
@ 2016-01-11 10:48 Julia Lawall
2016-01-14 9:00 ` Linus Walleij
0 siblings, 1 reply; 7+ messages in thread
From: Julia Lawall @ 2016-01-11 10:48 UTC (permalink / raw)
To: Laxman Dewangan
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
linus.walleij, gnurou, lee.jones, broonie, a.zummo,
alexandre.belloni, lgirdwood, devicetree, linux-kernel,
linux-gpio, rtc-linux, swarren, treding, Chaitanya Bandi
Make sure (of/i2c/platform)_device_id tables are NULL terminated
Generated by: scripts/coccinelle/misc/of_table.cocci
CC: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
Please take the patch only if it's a positive warning. Thanks!
gpio-max77620.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/gpio/gpio-max77620.c
+++ b/drivers/gpio/gpio-max77620.c
@@ -301,6 +301,7 @@ static struct platform_device_id max7762
{
.name = "max20024-gpio",
},
+ {},
};
static struct platform_driver max77620_gpio_driver = {
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: max77620: fix of_table.cocci warnings
2016-01-11 10:48 [PATCH] gpio: max77620: fix of_table.cocci warnings Julia Lawall
@ 2016-01-14 9:00 ` Linus Walleij
2016-01-14 9:47 ` Lee Jones
0 siblings, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2016-01-14 9:00 UTC (permalink / raw)
To: Julia Lawall, Lee Jones
Cc: Laxman Dewangan, Rob Herring, Paweł Moll, Mark Rutland,
ijc+devicetree@hellion.org.uk, Kumar Gala, Alexandre Courbot,
Mark Brown, Alessandro Zummo, Alexandre Belloni, Liam Girdwood,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com,
Stephen Warren, Thierry Reding, Chaitanya Bandi
On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>
> Generated by: scripts/coccinelle/misc/of_table.cocci
>
> CC: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
This is merged into the MFD subsystem for the moment so patches
have to go through Lee.
Alternatively I can go back and fix it up later.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: max77620: fix of_table.cocci warnings
2016-01-14 9:47 ` Lee Jones
@ 2016-01-14 9:39 ` Laxman Dewangan
2016-01-15 13:15 ` Linus Walleij
0 siblings, 1 reply; 7+ messages in thread
From: Laxman Dewangan @ 2016-01-14 9:39 UTC (permalink / raw)
To: Lee Jones, Linus Walleij
Cc: Julia Lawall, Rob Herring, Paweł Moll, Mark Rutland,
ijc+devicetree@hellion.org.uk, Kumar Gala, Alexandre Courbot,
Mark Brown, Alessandro Zummo, Alexandre Belloni, Liam Girdwood,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com,
Stephen Warren, Thierry Reding, Chaitanya Bandi
On Thursday 14 January 2016 03:17 PM, Lee Jones wrote:
> On Thu, 14 Jan 2016, Linus Walleij wrote:
>
>> On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>>
>>> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>>>
>>> Generated by: scripts/coccinelle/misc/of_table.cocci
>>>
>>> CC: Laxman Dewangan <ldewangan@nvidia.com>
>>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>>> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>>> ---
>>>
>>> Please take the patch only if it's a positive warning. Thanks!
>> This is merged into the MFD subsystem for the moment so patches
>> have to go through Lee.
>>
>> Alternatively I can go back and fix it up later.
> Pull request for v4.5 has already been sent.
>
> Feel free to take the patch into your tree post -rc1.
Is the driver gpio-max77620 applied?
I think still there is discussion going on the patches?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: max77620: fix of_table.cocci warnings
2016-01-14 9:00 ` Linus Walleij
@ 2016-01-14 9:47 ` Lee Jones
2016-01-14 9:39 ` Laxman Dewangan
0 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2016-01-14 9:47 UTC (permalink / raw)
To: Linus Walleij
Cc: Julia Lawall, Laxman Dewangan, Rob Herring, Paweł Moll,
Mark Rutland, ijc+devicetree@hellion.org.uk, Kumar Gala,
Alexandre Courbot, Mark Brown, Alessandro Zummo,
Alexandre Belloni, Liam Girdwood, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
rtc-linux@googlegroups.com, Stephen Warren, Thierry Reding,
Chaitanya Bandi
On Thu, 14 Jan 2016, Linus Walleij wrote:
> On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
> > Make sure (of/i2c/platform)_device_id tables are NULL terminated
> >
> > Generated by: scripts/coccinelle/misc/of_table.cocci
> >
> > CC: Laxman Dewangan <ldewangan@nvidia.com>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > ---
> >
> > Please take the patch only if it's a positive warning. Thanks!
>
> This is merged into the MFD subsystem for the moment so patches
> have to go through Lee.
>
> Alternatively I can go back and fix it up later.
Pull request for v4.5 has already been sent.
Feel free to take the patch into your tree post -rc1.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: max77620: fix of_table.cocci warnings
2016-01-14 9:39 ` Laxman Dewangan
@ 2016-01-15 13:15 ` Linus Walleij
[not found] ` <CACRpkdaV6e2SeAGE5C6_W6_0qbwMG6RaL+b+8o+JoyuJR-Y=Hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2016-01-15 13:15 UTC (permalink / raw)
To: Laxman Dewangan
Cc: Lee Jones, Julia Lawall, Rob Herring, Paweł Moll,
Mark Rutland, ijc+devicetree@hellion.org.uk, Kumar Gala,
Alexandre Courbot, Mark Brown, Alessandro Zummo,
Alexandre Belloni, Liam Girdwood, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
rtc-linux@googlegroups.com, Stephen Warren, Thierry Reding,
Chaitanya Bandi
On Thu, Jan 14, 2016 at 10:39 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> On Thursday 14 January 2016 03:17 PM, Lee Jones wrote:
>> On Thu, 14 Jan 2016, Linus Walleij wrote:
>>
>>> On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr>
>>> wrote:
>>>
>>>> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>>>>
>>>> Generated by: scripts/coccinelle/misc/of_table.cocci
>>>>
>>>> CC: Laxman Dewangan <ldewangan@nvidia.com>
>>>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>>>> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>>>> ---
>>>>
>>>> Please take the patch only if it's a positive warning. Thanks!
>>>
>>> This is merged into the MFD subsystem for the moment so patches
>>> have to go through Lee.
>>>
>>> Alternatively I can go back and fix it up later.
>>
>> Pull request for v4.5 has already been sent.
>>
>> Feel free to take the patch into your tree post -rc1.
>
> Is the driver gpio-max77620 applied?
Nah, I misunderstood it, don't worry. Lee just merged the core
driver(s). I have no idea what Julia's patch is based on, I was
confused by this mail so I assumed it was in the tree but it
was not. The world is full of mysteries :D
> I think still there is discussion going on the patches?
Sure let's work on this for the next cycle.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: max77620: fix of_table.cocci warnings
[not found] ` <CACRpkdaV6e2SeAGE5C6_W6_0qbwMG6RaL+b+8o+JoyuJR-Y=Hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-01-15 13:44 ` Julia Lawall
2016-01-18 12:08 ` Laxman Dewangan
1 sibling, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2016-01-15 13:44 UTC (permalink / raw)
To: Linus Walleij
Cc: Laxman Dewangan, Lee Jones, Julia Lawall, Rob Herring,
Paweł Moll, Mark Rutland,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
Kumar Gala, Alexandre Courbot, Mark Brown, Alessandro Zummo,
Alexandre Belloni, Liam Girdwood,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Stephen Warren,
Thierry Reding
On Fri, 15 Jan 2016, Linus Walleij wrote:
> On Thu, Jan 14, 2016 at 10:39 AM, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
> > On Thursday 14 January 2016 03:17 PM, Lee Jones wrote:
> >> On Thu, 14 Jan 2016, Linus Walleij wrote:
> >>
> >>> On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
> >>> wrote:
> >>>
> >>>> Make sure (of/i2c/platform)_device_id tables are NULL terminated
> >>>>
> >>>> Generated by: scripts/coccinelle/misc/of_table.cocci
> >>>>
> >>>> CC: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >>>> Signed-off-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >>>> Signed-off-by: Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
> >>>> ---
> >>>>
> >>>> Please take the patch only if it's a positive warning. Thanks!
> >>>
> >>> This is merged into the MFD subsystem for the moment so patches
> >>> have to go through Lee.
> >>>
> >>> Alternatively I can go back and fix it up later.
> >>
> >> Pull request for v4.5 has already been sent.
> >>
> >> Feel free to take the patch into your tree post -rc1.
> >
> > Is the driver gpio-max77620 applied?
>
> Nah, I misunderstood it, don't worry. Lee just merged the core
> driver(s). I have no idea what Julia's patch is based on, I was
> confused by this mail so I assumed it was in the tree but it
> was not. The world is full of mysteries :D
I don't know either. It came to me via kbuild. It may be derived from a
submitted patch rather than aready committed code.
julia
>
> > I think still there is discussion going on the patches?
>
> Sure let's work on this for the next cycle.
>
> Yours,
> Linus Walleij
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: max77620: fix of_table.cocci warnings
[not found] ` <CACRpkdaV6e2SeAGE5C6_W6_0qbwMG6RaL+b+8o+JoyuJR-Y=Hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-15 13:44 ` Julia Lawall
@ 2016-01-18 12:08 ` Laxman Dewangan
1 sibling, 0 replies; 7+ messages in thread
From: Laxman Dewangan @ 2016-01-18 12:08 UTC (permalink / raw)
To: Linus Walleij
Cc: Lee Jones, Julia Lawall, Rob Herring, Paweł Moll,
Mark Rutland,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
Kumar Gala, Alexandre Courbot, Mark Brown, Alessandro Zummo,
Alexandre Belloni, Liam Girdwood,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Stephen Warren,
Thierry Reding, Chaitanya Bandi
On Friday 15 January 2016 06:45 PM, Linus Walleij wrote:
> On Thu, Jan 14, 2016 at 10:39 AM, Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
>> I think still there is discussion going on the patches?
> Sure let's work on this for the next cycle.
>
>
I have fixed this in V3 version and sent for review.
Please help to review it.
Thanks,
Laxman
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-01-18 12:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-11 10:48 [PATCH] gpio: max77620: fix of_table.cocci warnings Julia Lawall
2016-01-14 9:00 ` Linus Walleij
2016-01-14 9:47 ` Lee Jones
2016-01-14 9:39 ` Laxman Dewangan
2016-01-15 13:15 ` Linus Walleij
[not found] ` <CACRpkdaV6e2SeAGE5C6_W6_0qbwMG6RaL+b+8o+JoyuJR-Y=Hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-15 13:44 ` Julia Lawall
2016-01-18 12:08 ` Laxman Dewangan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).