From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v5 2/2] gpio: sn65hvs885: Add DT binding documentation Date: Thu, 28 Jan 2016 20:43:35 -0600 Message-ID: <20160129024335.GA5772@rob-hp-laptop> References: <1453793566-31363-1-git-send-email-sean.nyekjaer@prevas.dk> <1453793566-31363-2-git-send-email-sean.nyekjaer@prevas.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.kernel.org ([198.145.29.136]:58359 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbcA2Cnk (ORCPT ); Thu, 28 Jan 2016 21:43:40 -0500 Content-Disposition: inline In-Reply-To: <1453793566-31363-2-git-send-email-sean.nyekjaer@prevas.dk> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Sean Nyekjaer Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, "Andrew F. Davis" , Linus Walleij On Tue, Jan 26, 2016 at 08:32:46AM +0100, Sean Nyekjaer wrote: > Signed-off-by: Sean Nyekjaer > --- > Changes since v4: > - Added description, required properties > - Tested and added support for gpio polarity > - Added vendor prefix to compatible flags > > Changes since v3: > - Added gpio-controller and gpio cells flags > > .../devicetree/bindings/gpio/gpio-sn65hvs885.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt This looks fine, but I just realized this is the same thing as this[1]. Please coordinate these bindings. Rob [1] https://lkml.org/lkml/2016/1/25/781 > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt b/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt > new file mode 100644 > index 0000000..c9b3592 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt > @@ -0,0 +1,20 @@ > +* TI SN65HVS885 digital-input serializer > + > +Required properties: > +- compatible : Should be "ti,sn65hvs885" > +- reg : chip select number > +- gpio-controller : Marks the device node as a gpio controller. > +- #gpio-cells : Should be two. The first cell is the pin number and > + the second cell is used to specify the gpio polarity: > + 0 = active high > + 1 = active low > + > +Example: > +sn65hvs885@3 { > + compatible = "ti,sn65hvs885"; > + spi-max-frequency = <10000000>; > + latch-gpio = <&gpio4 1 GPIO_ACTIVE_HIGH>; > + reg = <0>; > + gpio-controller; > + #gpio-cells = <2>; > +}; > -- > 2.7.0 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html