* [PATCH] pinctrl: sunxi: H3 requires irq_read_needs_mux
@ 2016-02-02 10:03 Krzysztof Adamski
2016-02-02 13:24 ` Maxime Ripard
2016-02-11 12:01 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Adamski @ 2016-02-02 10:03 UTC (permalink / raw)
Cc: Linus Walleij, Maxime Ripard, Chen-Yu Tsai, Hans de Goede,
Hongzhou Yang, Rob Herring, Jens Kuske, Fabian Frederick,
Krzysztof Adamski, Vishnu Patekar, linux-gpio, linux-arm-kernel,
linux-kernel
It seems that on H3, just like on A10, when GPIOs are configured as
external interrupt data registers does not contain their value. When
value is read, GPIO function must be temporary switched to input for
reads.
Signed-off-by: Krzysztof Adamski <k@japko.eu>
---
drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
index 77d4cf0..11760bb 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
@@ -492,6 +492,7 @@ static const struct sunxi_pinctrl_desc sun8i_h3_pinctrl_data = {
.pins = sun8i_h3_pins,
.npins = ARRAY_SIZE(sun8i_h3_pins),
.irq_banks = 2,
+ .irq_read_needs_mux = true
};
static int sun8i_h3_pinctrl_probe(struct platform_device *pdev)
--
2.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: sunxi: H3 requires irq_read_needs_mux
2016-02-02 10:03 [PATCH] pinctrl: sunxi: H3 requires irq_read_needs_mux Krzysztof Adamski
@ 2016-02-02 13:24 ` Maxime Ripard
2016-02-11 12:01 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2016-02-02 13:24 UTC (permalink / raw)
To: Krzysztof Adamski
Cc: Linus Walleij, Chen-Yu Tsai, Hans de Goede, Hongzhou Yang,
Rob Herring, Jens Kuske, Fabian Frederick, Vishnu Patekar,
linux-gpio, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
On Tue, Feb 02, 2016 at 11:03:03AM +0100, Krzysztof Adamski wrote:
> It seems that on H3, just like on A10, when GPIOs are configured as
> external interrupt data registers does not contain their value. When
> value is read, GPIO function must be temporary switched to input for
> reads.
>
> Signed-off-by: Krzysztof Adamski <k@japko.eu>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: sunxi: H3 requires irq_read_needs_mux
2016-02-02 10:03 [PATCH] pinctrl: sunxi: H3 requires irq_read_needs_mux Krzysztof Adamski
2016-02-02 13:24 ` Maxime Ripard
@ 2016-02-11 12:01 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-02-11 12:01 UTC (permalink / raw)
To: Krzysztof Adamski
Cc: Maxime Ripard, Chen-Yu Tsai, Hans de Goede, Hongzhou Yang,
Rob Herring, Jens Kuske, Fabian Frederick, Vishnu Patekar,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Tue, Feb 2, 2016 at 11:03 AM, Krzysztof Adamski
<krzysztof.adamski@sonymobile.com> wrote:
> It seems that on H3, just like on A10, when GPIOs are configured as
> external interrupt data registers does not contain their value. When
> value is read, GPIO function must be temporary switched to input for
> reads.
>
> Signed-off-by: Krzysztof Adamski <k@japko.eu>
Patch applied for fixes with Maxime's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-11 12:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-02 10:03 [PATCH] pinctrl: sunxi: H3 requires irq_read_needs_mux Krzysztof Adamski
2016-02-02 13:24 ` Maxime Ripard
2016-02-11 12:01 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).