From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 2/5] dts: sun8i-h3: Add APB0 related clocks and resets Date: Wed, 3 Feb 2016 13:35:34 +0100 Message-ID: <20160203123534.GG4652@lukather> References: <1454448113-18810-1-git-send-email-k@japko.eu> <1454448113-18810-3-git-send-email-k@japko.eu> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PDbbKmIEKQ49+rCF" Return-path: Content-Disposition: inline In-Reply-To: <1454448113-18810-3-git-send-email-k-P4rZei/IPtg@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Krzysztof Adamski Cc: Linus Walleij , Chen-Yu Tsai , Rob Herring , Hans de Goede , Vishnu Patekar , Jens Kuske , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: linux-gpio@vger.kernel.org --PDbbKmIEKQ49+rCF Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi, On Tue, Feb 02, 2016 at 10:21:50PM +0100, Krzysztof Adamski wrote: > APB0 is bearly mentioned in H3 User Manual and it is only setup in the > Allwinners kernel dump for CIR. I have verified experimentally that the > gate for R_PIO exists and works, though. There are probably other gates > there but I don't know their order right now and I don't have access to > their peripherals on my board to test them. > > Signed-off-by: Krzysztof Adamski > --- > arch/arm/boot/dts/sun8i-h3.dtsi | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > index 1524130e..ce35e93 100644 > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > @@ -276,6 +276,32 @@ > clocks = <&osc24M>, <&pll6 1>, <&pll5>; > clock-output-names = "mbus"; > }; > + > + ahb0: ahb0_clk { > + compatible = "fixed-factor-clock"; > + #clock-cells = <0>; > + clock-div = <1>; > + clock-mult = <1>; > + clocks = <&osc24M>, <&osc32k>; > + clock-output-names = "ahb0"; > + }; I'm not sure what you mean there. The fixed factor clocks only take a single parent, and you provided two. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --PDbbKmIEKQ49+rCF--