From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Vishnu Patekar
<vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jonathan Corbet <corbet-T1hC0tSOHrs@public.gmane.org>,
"pawel.moll-5wv7dgnIgG8@public.gmane.org"
<pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"mark.rutland-5wv7dgnIgG8@public.gmane.org"
<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Emilio Lopez <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>,
Jens Kuske <jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org"
<linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Reinde
Subject: Re: [PATCH 04/14] clk: sunxi: add ahb1 clock for A83T
Date: Thu, 4 Feb 2016 09:01:09 +0100 [thread overview]
Message-ID: <20160204080109.GA4270@lukather> (raw)
In-Reply-To: <CAEzqOZuBz2jexvZvvtkvjbE8UtzUMKL9nT5JJ9JcvMPmzEKTcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On Thu, Feb 04, 2016 at 02:06:45PM +0800, Vishnu Patekar wrote:
> Hello Maxime,
>
>
> On Tue, Feb 2, 2016 at 9:17 PM, Maxime Ripard
> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > Hi,
> >
> > On Sun, Jan 31, 2016 at 09:20:56AM +0800, Vishnu Patekar wrote:
> >> AHB1 on A83T is similar to ahb1 on A31, except parents are different.
> >> clock index 0b1x is PLL6.
> >>
> >> Signed-off-by: Vishnu Patekar <vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> > If the clock is the same but the parents are different, then we don't
> > need to duplicate all the logic. Simply add the number of parents to
> > mux_data, and you're all set.
>
> Problem here is: parent 0b10 for A31 ahb1 is AXI, 0b11 is pll6/pre_div.
> 0b10 and 0b11 is pll6/pre_div.
> So, just adding number of parents to mux_data will not solve problem.
Is anyone using 0b11 ? Can't we just ignore it?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-04 8:01 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 1:20 [PATCH 00/14] Add A83T clk, r_pio, mmc rsb support Vishnu Patekar
[not found] ` <1454203266-4450-1-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-31 1:20 ` [PATCH 01/14] pinctrl: sunxi: Add A83T R_PIO controller support Vishnu Patekar
[not found] ` <1454203266-4450-2-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-31 3:28 ` Chen-Yu Tsai
2016-02-11 11:59 ` Linus Walleij
2016-02-11 12:36 ` Maxime Ripard
2016-02-11 13:47 ` Linus Walleij
2016-02-11 15:12 ` Maxime Ripard
2016-02-15 23:23 ` Linus Walleij
[not found] ` <CACRpkdb7=x2bJP1nXpF2bP3U0t+NUHiuw_aeTAhbR8OXOrHn6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-25 0:56 ` Maxime Ripard
2016-02-25 14:49 ` Linus Walleij
2016-02-01 15:00 ` Rob Herring
2016-01-31 1:20 ` [PATCH 02/14] clk: sunxi: Add apb0 gates for A83T Vishnu Patekar
[not found] ` <1454203266-4450-3-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-01 15:02 ` Rob Herring
2016-02-01 15:11 ` Chen-Yu Tsai
2016-02-02 13:12 ` Maxime Ripard
2016-01-31 1:20 ` [PATCH 03/14] clk: sunxi: add bus " Vishnu Patekar
2016-02-01 15:03 ` Rob Herring
2016-02-01 15:13 ` Chen-Yu Tsai
[not found] ` <1454203266-4450-4-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-02 13:13 ` Maxime Ripard
2016-01-31 1:20 ` [PATCH 04/14] clk: sunxi: add ahb1 clock " Vishnu Patekar
2016-02-01 14:49 ` Rob Herring
2016-02-01 14:54 ` Chen-Yu Tsai
2016-02-02 13:17 ` Maxime Ripard
2016-02-04 6:06 ` Vishnu Patekar
[not found] ` <CAEzqOZuBz2jexvZvvtkvjbE8UtzUMKL9nT5JJ9JcvMPmzEKTcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-04 8:01 ` Maxime Ripard [this message]
2016-02-12 5:24 ` Vishnu Patekar
2016-01-31 1:20 ` [PATCH 05/14] clk: sunxi: Add APB1 " Vishnu Patekar
[not found] ` <1454203266-4450-6-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-31 3:33 ` Chen-Yu Tsai
2016-02-01 14:50 ` Rob Herring
2016-01-31 1:20 ` [PATCH 06/14] ARM: dts: sun8i-a83t: Correct low speed oscillator clocks Vishnu Patekar
[not found] ` <1454203266-4450-7-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-02 13:18 ` Maxime Ripard
2016-02-02 13:19 ` Maxime Ripard
2016-02-04 8:51 ` Vishnu Patekar
[not found] ` <CAEzqOZvcy58T_uxvymGxuQXh_Goj3yHmgkmL4VL+x2_bycMgNg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-04 12:04 ` Maxime Ripard
2016-01-31 1:20 ` [PATCH 07/14] ARM: dts: sun8i-a83t: Add basic clocks and resets Vishnu Patekar
[not found] ` <1454203266-4450-8-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-31 6:06 ` Chen-Yu Tsai
2016-01-31 1:21 ` [PATCH 08/14] ARM: dts: sun8i-a83t: add mmc clock nodes Vishnu Patekar
[not found] ` <1454203266-4450-9-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-31 6:10 ` Chen-Yu Tsai
2016-01-31 1:21 ` [PATCH 09/14] ARM: dts: sun8i-a83t: Add mmc controller nodes Vishnu Patekar
2016-02-02 6:35 ` Chen-Yu Tsai
2016-01-31 1:21 ` [PATCH 10/14] ARM: dts: sun8i-a83t: Add PRCM related clocks and resets Vishnu Patekar
2016-02-02 6:44 ` Chen-Yu Tsai
[not found] ` <CAGb2v67iO-816KaLttWRRPL2f7hpfgJ1--p69tD_oOrewmOjCA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-12 16:06 ` Vishnu Patekar
2016-02-12 16:43 ` Chen-Yu Tsai
[not found] ` <CAGb2v65cfG=cJ91+9G5uS5XcUh0nx6-7ZnMr7RjSGqXPHjyxpQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-15 9:34 ` Chen-Yu Tsai
2016-02-15 9:55 ` Chen-Yu Tsai
2016-01-31 1:21 ` [PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi Vishnu Patekar
[not found] ` <1454203266-4450-12-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-31 3:46 ` Chen-Yu Tsai
2016-01-31 1:21 ` [PATCH 12/14] ARM: dts: sun8i-a83t: Add RSB nodes to dtsi Vishnu Patekar
2016-01-31 3:50 ` Chen-Yu Tsai
2016-01-31 1:21 ` [PATCH 13/14] ARM: dts: sun8i: enable mmc for H8Homlet Board Vishnu Patekar
[not found] ` <1454203266-4450-14-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-02 7:31 ` Chen-Yu Tsai
2016-01-31 1:21 ` [PATCH 14/14] ARM: dts: sun8i: Add A83T based Sinovoip Bpi-M3 Board Vishnu Patekar
2016-02-02 7:37 ` Chen-Yu Tsai
[not found] ` <CAGb2v65BwAcT8920WXt7dBjNx4zjycw2Ea+sNZrm0aM_3JA8pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-04 4:25 ` Vishnu Patekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204080109.GA4270@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=corbet-T1hC0tSOHrs@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).