* [PATCH] pinctrl: intel: Remove unneeded header includes
@ 2016-02-12 10:13 Jean Delvare
2016-02-12 10:46 ` Mika Westerberg
2016-02-12 12:57 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Jean Delvare @ 2016-02-12 10:13 UTC (permalink / raw)
To: linux-gpio; +Cc: Mika Westerberg, Heikki Krogerus, Linus Walleij, Mathias Nyman
pinctrl-intel doesn't use anything from <linux/init.h>,
<linux/acpi.h>, <linux/gpio.h> or <linux/pm.h>, so it should not
include these header files.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
drivers/pinctrl/intel/pinctrl-intel.c | 4 ----
1 file changed, 4 deletions(-)
--- linux-4.5-rc3.orig/drivers/pinctrl/intel/pinctrl-intel.c 2016-02-02 09:02:08.805929741 +0100
+++ linux-4.5-rc3/drivers/pinctrl/intel/pinctrl-intel.c 2016-02-12 11:03:56.554164885 +0100
@@ -11,13 +11,9 @@
*/
#include <linux/module.h>
-#include <linux/init.h>
#include <linux/interrupt.h>
-#include <linux/acpi.h>
-#include <linux/gpio.h>
#include <linux/gpio/driver.h>
#include <linux/platform_device.h>
-#include <linux/pm.h>
#include <linux/pinctrl/pinctrl.h>
#include <linux/pinctrl/pinmux.h>
#include <linux/pinctrl/pinconf.h>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: intel: Remove unneeded header includes
2016-02-12 10:13 [PATCH] pinctrl: intel: Remove unneeded header includes Jean Delvare
@ 2016-02-12 10:46 ` Mika Westerberg
2016-02-12 12:57 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2016-02-12 10:46 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-gpio, Heikki Krogerus, Linus Walleij, Mathias Nyman
On Fri, Feb 12, 2016 at 11:13:13AM +0100, Jean Delvare wrote:
> pinctrl-intel doesn't use anything from <linux/init.h>,
> <linux/acpi.h>, <linux/gpio.h> or <linux/pm.h>, so it should not
> include these header files.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: intel: Remove unneeded header includes
2016-02-12 10:13 [PATCH] pinctrl: intel: Remove unneeded header includes Jean Delvare
2016-02-12 10:46 ` Mika Westerberg
@ 2016-02-12 12:57 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-02-12 12:57 UTC (permalink / raw)
To: Jean Delvare
Cc: linux-gpio@vger.kernel.org, Mika Westerberg, Heikki Krogerus,
Mathias Nyman
On Fri, Feb 12, 2016 at 11:13 AM, Jean Delvare <jdelvare@suse.de> wrote:
> pinctrl-intel doesn't use anything from <linux/init.h>,
> <linux/acpi.h>, <linux/gpio.h> or <linux/pm.h>, so it should not
> include these header files.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
Patch applied with Mika's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-12 12:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-12 10:13 [PATCH] pinctrl: intel: Remove unneeded header includes Jean Delvare
2016-02-12 10:46 ` Mika Westerberg
2016-02-12 12:57 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).