From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>,
Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH] gpio/pinctrl: sunxi: stop poking around in private vars
Date: Tue, 16 Feb 2016 09:08:27 +0100 [thread overview]
Message-ID: <20160216080827.GB4344@lukather> (raw)
In-Reply-To: <1455218943-25917-1-git-send-email-linus.walleij@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
Hi Linus,
On Thu, Feb 11, 2016 at 08:29:03PM +0100, Linus Walleij wrote:
> This kind of hacks disturbs the refactoring of the gpiolib.
>
> The descriptor table belongs to the gpiolib, if we want to know
> something about something in it, use or define the proper accessor
> functions. Let's add this gpiochip_lins_is_irq() to do what the
> sunxi driver is trying at so we can privatize the descriptors
> properly.
>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
It looks ok.
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-02-16 8:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 19:29 [PATCH] gpio/pinctrl: sunxi: stop poking around in private vars Linus Walleij
2016-02-16 8:08 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216080827.GB4344@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox