From: Nicolas Saenz Julienne <nicolassaenzj@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] gpio: create an API to detect open drain/source on lines
Date: Thu, 18 Feb 2016 21:20:40 +0000 [thread overview]
Message-ID: <20160218212032.GA3699@vian> (raw)
In-Reply-To: <CACRpkdYmhRrfMgdoxh7oV1p4swaRRZ+sGPM_AU6+KD_JL8R6NA@mail.gmail.com>
On Thu, Feb 18, 2016 at 09:47:07PM +0100, Linus Walleij wrote:
> On Wed, Feb 17, 2016 at 1:21 AM, Nicolas Saenz Julienne
> <nicolassaenzj@gmail.com> wrote:
> > On Tue, Feb 16, 2016 at 03:46:19PM +0100, Linus Walleij wrote:
> >> My left hand merges code to privatize the descriptor handling
> >> while my right hand merges drivers that poke around and
> >> disrespect with the same gpiolib internals.
> >>
> >> So let's expose the proper APIs for drivers to ask the gpiolib
> >> core if a line is marked as open drain or open source and
> >> get some order around things so this driver compiles again.
> >
> > Thanks, looks way better now, I'd suggest to remove the "gpiolib.h"
> > include since it's not needed anymore. I can do it's on a separate patch
> > on top of this one if you prefer :)
Sorry I wasn't more clear. What I meant to say it's that we can now remove the
#include "gpiolib.h" from gpio-tps65218 driver since the line config query
functions are included in "gpio/driver.h".
--
Nicolas
prev parent reply other threads:[~2016-02-18 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 14:46 [PATCH] gpio: create an API to detect open drain/source on lines Linus Walleij
2016-02-17 0:21 ` Nicolas Saenz Julienne
2016-02-18 20:47 ` Linus Walleij
2016-02-18 21:20 ` Nicolas Saenz Julienne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218212032.GA3699@vian \
--to=nicolassaenzj@gmail.com \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).