From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 19/50] pinctrl: ssbi-gpi: Use devm_pinctrl_register() for pinctrl registration Date: Wed, 24 Feb 2016 10:08:41 -0800 Message-ID: <20160224180841.GM21240@tuxbot> References: <1456319775-3216-1-git-send-email-ldewangan@nvidia.com> <1456319775-3216-20-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1456319775-3216-20-git-send-email-ldewangan@nvidia.com> Sender: linux-doc-owner@vger.kernel.org To: Laxman Dewangan Cc: linus.walleij@linaro.org, corbet@lwn.net, lee@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org, Bjorn Andersson List-Id: linux-gpio@vger.kernel.org On Wed 24 Feb 05:15 PST 2016, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > the error path. > > Signed-off-by: Laxman Dewangan > Cc: Bjorn Andersson > --- Reviewed-by: Bjorn Andersson Regards, Bjorn > drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c > index cd8580d..f71dda6 100644 > --- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c > +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c > @@ -729,7 +729,7 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev) > pctrl->desc.custom_conf_items = pm8xxx_conf_items; > #endif > > - pctrl->pctrl = pinctrl_register(&pctrl->desc, &pdev->dev, pctrl); > + pctrl->pctrl = devm_pinctrl_register(&pdev->dev, &pctrl->desc, pctrl); > if (IS_ERR(pctrl->pctrl)) { > dev_err(&pdev->dev, "couldn't register pm8xxx gpio driver\n"); > return PTR_ERR(pctrl->pctrl); > @@ -745,7 +745,7 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev) > ret = gpiochip_add_data(&pctrl->chip, pctrl); > if (ret) { > dev_err(&pdev->dev, "failed register gpiochip\n"); > - goto unregister_pinctrl; > + return ret; > } > > ret = gpiochip_add_pin_range(&pctrl->chip, > @@ -765,9 +765,6 @@ static int pm8xxx_gpio_probe(struct platform_device *pdev) > unregister_gpiochip: > gpiochip_remove(&pctrl->chip); > > -unregister_pinctrl: > - pinctrl_unregister(pctrl->pctrl); > - > return ret; > } > > @@ -777,8 +774,6 @@ static int pm8xxx_gpio_remove(struct platform_device *pdev) > > gpiochip_remove(&pctrl->chip); > > - pinctrl_unregister(pctrl->pctrl); > - > return 0; > } > > -- > 2.1.4 >