From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 1/2] pinctrl: sunxi: Remove non existing irq's Date: Mon, 29 Feb 2016 20:43:28 -0800 Message-ID: <20160301044328.GE8418@lukather> References: Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3O1VwFp74L81IIeR" Return-path: Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Henry Paulissen Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Linus Walleij , Chen-Yu Tsai , Hongzhou Yang , Fabian Frederick , Patrice Chotard , "open list:PIN CONTROL SUBSYSTEM" , "moderated list:ARM/Allwinner sunXi SoC support" , open list List-Id: linux-gpio@vger.kernel.org --3O1VwFp74L81IIeR Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Mon, Feb 29, 2016 at 12:13:26AM +0100, Henry Paulissen wrote: > While I was testing irq's on the cubietruck I found a couple of > not working irq pins. Further diving into the problem it opened > up a mess called "manual". > > This so called manual (A20 user manual v1.3 dated 2014-10-10) says: > > Pin overview: > Page 233: EINT12 is on pin PC19 mux6. > Page 236: EINT12 is on pin PH12 mux6. > > Now, it is a bit strange to have the same IRQ on 2 different pins, > but I guess this could still be possible hardware wise. But then: > > Pin registers: > Page 253: EINT12 is *not* on pin PC19. > Page 281: EINT12 is on pin PH12. > > The manual is so contradicting that further tests had to be made > to see which of the 2 statements where correct. > > This patch is based on actual outcome of these tests and not what > the manual says. > > Test procedure used: > > Connect a 1 pulse per second (GPS) line to the pin. > > echo pin### > /sys/class/gpio/export > echo in > /sys/class/gpio/gpio###/direction > echo rising > /sys/class/gpio/gpio###/edge > > Check /proc/interrupts if a irq was attached and if irq's where > received. > > Signed-off-by: Henry Paulissen Acked-by: Maxime Ripard Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --3O1VwFp74L81IIeR--