From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Tero Kristo <t-kristo@ti.com>, Dave Gerlach <d-gerlach@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 0/3] OMAP/pinmux: remove misuse of IRQF_NO_SUSPEND flag
Date: Tue, 8 Mar 2016 09:09:09 -0800 [thread overview]
Message-ID: <20160308170909.GC9329@atomide.com> (raw)
In-Reply-To: <56DEB82F.5050703@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [160308 03:32]:
>
> Yeah. As I mentioned before patches 2/3 will not work.
> I've tried to test suspend with diff I posted [1], but I did it only on
> dra7 and am43 where suspend i more simple than on omap3. Also, I worry
> that with such approach some irq can be missed (especially edge ones),
> because PRCM irqs will be re-enabled at very late resume stage
> (right before thaw).
Yeah any tests not done with PM on omap3 with the mainline kernel
are clearly incomplete in this case :)
> Second option, I see, is to rework PRCM to be threaded IRQ, but in this case
> all children IRQs will need to be threaded/nested threaded
> (including PCS, legacy OMAP mux, OMAP3 _prcm_int_handle_wakeup/_prcm_int_handle_io).
>
> Are there any objection to convert PCS to threaded IRQ, for example? ;)
For PRCM interrupt, I don't think that can be threaded IRQ as
that thing is firing all the time. The consumers for the chained
PRCM interrupt consumers like PCS could probably use threaded IRQ.
When the PCS interrupts fire, we're already in some sleeper
idle state so the extra latency thre does not matter.
Regards,
Tony
> [1] https://patchwork.ozlabs.org/patch/578915/
prev parent reply other threads:[~2016-03-08 17:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 18:28 [PATCH 0/3] OMAP/pinmux: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2016-02-01 18:28 ` [PATCH 1/3] pinctrl: single: Use a separate lockdep class Sudeep Holla
2016-03-08 11:32 ` Grygorii Strashko
2016-03-11 16:04 ` Linus Walleij
2016-02-01 18:28 ` [PATCH 2/3] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2016-02-01 18:28 ` [PATCH 3/3] ARM: OMAP2+: " Sudeep Holla
2016-02-04 13:14 ` Grygorii Strashko
2016-02-04 13:34 ` Sudeep Holla
2016-02-13 14:42 ` [PATCH 0/3] OMAP/pinmux: " Linus Walleij
2016-02-15 10:01 ` Sudeep Holla
2016-02-15 15:27 ` Tony Lindgren
2016-03-08 11:31 ` Grygorii Strashko
2016-03-08 17:09 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308170909.GC9329@atomide.com \
--to=tony@atomide.com \
--cc=d-gerlach@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).