* [PATCH] gpio: lp3943: Drop pin_used and lp3943_gpio_request/lp3943_gpio_free
@ 2016-02-29 13:08 Axel Lin
2016-03-09 2:18 ` Linus Walleij
2016-03-09 5:37 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2016-02-29 13:08 UTC (permalink / raw)
To: Linus Walleij; +Cc: Milo Kim, Alexandre Courbot, Lee Jones, linux-gpio
The implementation of lp3943_gpio_request/lp3943_gpio_free test pin_used
for tracing the pin usage. However, gpiolib already checks FLAG_REQUESTED
flag for the same purpose. So remove the redundant implementation.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-lp3943.c | 22 ----------------------
include/linux/mfd/lp3943.h | 6 ------
2 files changed, 28 deletions(-)
diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
index 1c8e2ae..9d26ad4 100644
--- a/drivers/gpio/gpio-lp3943.c
+++ b/drivers/gpio/gpio-lp3943.c
@@ -45,26 +45,6 @@ struct lp3943_gpio {
u16 input_mask; /* 1 = GPIO is input direction, 0 = output */
};
-static int lp3943_gpio_request(struct gpio_chip *chip, unsigned offset)
-{
- struct lp3943_gpio *lp3943_gpio = gpiochip_get_data(chip);
- struct lp3943 *lp3943 = lp3943_gpio->lp3943;
-
- /* Return an error if the pin is already assigned */
- if (test_and_set_bit(offset, &lp3943->pin_used))
- return -EBUSY;
-
- return 0;
-}
-
-static void lp3943_gpio_free(struct gpio_chip *chip, unsigned offset)
-{
- struct lp3943_gpio *lp3943_gpio = gpiochip_get_data(chip);
- struct lp3943 *lp3943 = lp3943_gpio->lp3943;
-
- clear_bit(offset, &lp3943->pin_used);
-}
-
static int lp3943_gpio_set_mode(struct lp3943_gpio *lp3943_gpio, u8 offset,
u8 val)
{
@@ -177,8 +157,6 @@ static int lp3943_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
static const struct gpio_chip lp3943_gpio_chip = {
.label = "lp3943",
.owner = THIS_MODULE,
- .request = lp3943_gpio_request,
- .free = lp3943_gpio_free,
.direction_input = lp3943_gpio_direction_input,
.get = lp3943_gpio_get,
.direction_output = lp3943_gpio_direction_output,
diff --git a/include/linux/mfd/lp3943.h b/include/linux/mfd/lp3943.h
index 3490db7..d3a73811 100644
--- a/include/linux/mfd/lp3943.h
+++ b/include/linux/mfd/lp3943.h
@@ -94,18 +94,12 @@ struct lp3943_reg_cfg {
* @regmap: Used for I2C communication on accessing registers
* @pdata: LP3943 platform specific data
* @mux_cfg: Register configuration for pin MUX
- * @pin_used: Bit mask for output pin used.
- * This bitmask is used for pin assignment management.
- * 1 = pin used, 0 = available.
- * Only LSB 16 bits are used, but it is unsigned long type
- * for atomic bitwise operations.
*/
struct lp3943 {
struct device *dev;
struct regmap *regmap;
struct lp3943_platform_data *pdata;
const struct lp3943_reg_cfg *mux_cfg;
- unsigned long pin_used;
};
int lp3943_read_byte(struct lp3943 *lp3943, u8 reg, u8 *read);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: lp3943: Drop pin_used and lp3943_gpio_request/lp3943_gpio_free
2016-02-29 13:08 [PATCH] gpio: lp3943: Drop pin_used and lp3943_gpio_request/lp3943_gpio_free Axel Lin
@ 2016-03-09 2:18 ` Linus Walleij
2016-03-09 5:37 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-03-09 2:18 UTC (permalink / raw)
To: Axel Lin; +Cc: Milo Kim, Alexandre Courbot, Lee Jones,
linux-gpio@vger.kernel.org
On Mon, Feb 29, 2016 at 8:08 PM, Axel Lin <axel.lin@ingics.com> wrote:
> The implementation of lp3943_gpio_request/lp3943_gpio_free test pin_used
> for tracing the pin usage. However, gpiolib already checks FLAG_REQUESTED
> flag for the same purpose. So remove the redundant implementation.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Nice catch! Thanks for reading through all drivers with this scrutiny,
patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: lp3943: Drop pin_used and lp3943_gpio_request/lp3943_gpio_free
2016-02-29 13:08 [PATCH] gpio: lp3943: Drop pin_used and lp3943_gpio_request/lp3943_gpio_free Axel Lin
2016-03-09 2:18 ` Linus Walleij
@ 2016-03-09 5:37 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2016-03-09 5:37 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, Milo Kim, Alexandre Courbot, linux-gpio
On Mon, 29 Feb 2016, Axel Lin wrote:
> The implementation of lp3943_gpio_request/lp3943_gpio_free test pin_used
> for tracing the pin usage. However, gpiolib already checks FLAG_REQUESTED
> flag for the same purpose. So remove the redundant implementation.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/gpio-lp3943.c | 22 ----------------------
> include/linux/mfd/lp3943.h | 6 ------
> 2 files changed, 28 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c
> index 1c8e2ae..9d26ad4 100644
> --- a/drivers/gpio/gpio-lp3943.c
> +++ b/drivers/gpio/gpio-lp3943.c
> @@ -45,26 +45,6 @@ struct lp3943_gpio {
> u16 input_mask; /* 1 = GPIO is input direction, 0 = output */
> };
>
> -static int lp3943_gpio_request(struct gpio_chip *chip, unsigned offset)
> -{
> - struct lp3943_gpio *lp3943_gpio = gpiochip_get_data(chip);
> - struct lp3943 *lp3943 = lp3943_gpio->lp3943;
> -
> - /* Return an error if the pin is already assigned */
> - if (test_and_set_bit(offset, &lp3943->pin_used))
> - return -EBUSY;
> -
> - return 0;
> -}
> -
> -static void lp3943_gpio_free(struct gpio_chip *chip, unsigned offset)
> -{
> - struct lp3943_gpio *lp3943_gpio = gpiochip_get_data(chip);
> - struct lp3943 *lp3943 = lp3943_gpio->lp3943;
> -
> - clear_bit(offset, &lp3943->pin_used);
> -}
> -
> static int lp3943_gpio_set_mode(struct lp3943_gpio *lp3943_gpio, u8 offset,
> u8 val)
> {
> @@ -177,8 +157,6 @@ static int lp3943_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
> static const struct gpio_chip lp3943_gpio_chip = {
> .label = "lp3943",
> .owner = THIS_MODULE,
> - .request = lp3943_gpio_request,
> - .free = lp3943_gpio_free,
> .direction_input = lp3943_gpio_direction_input,
> .get = lp3943_gpio_get,
> .direction_output = lp3943_gpio_direction_output,
> diff --git a/include/linux/mfd/lp3943.h b/include/linux/mfd/lp3943.h
> index 3490db7..d3a73811 100644
> --- a/include/linux/mfd/lp3943.h
> +++ b/include/linux/mfd/lp3943.h
> @@ -94,18 +94,12 @@ struct lp3943_reg_cfg {
> * @regmap: Used for I2C communication on accessing registers
> * @pdata: LP3943 platform specific data
> * @mux_cfg: Register configuration for pin MUX
> - * @pin_used: Bit mask for output pin used.
> - * This bitmask is used for pin assignment management.
> - * 1 = pin used, 0 = available.
> - * Only LSB 16 bits are used, but it is unsigned long type
> - * for atomic bitwise operations.
> */
> struct lp3943 {
> struct device *dev;
> struct regmap *regmap;
> struct lp3943_platform_data *pdata;
> const struct lp3943_reg_cfg *mux_cfg;
> - unsigned long pin_used;
> };
>
> int lp3943_read_byte(struct lp3943 *lp3943, u8 reg, u8 *read);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-09 5:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-29 13:08 [PATCH] gpio: lp3943: Drop pin_used and lp3943_gpio_request/lp3943_gpio_free Axel Lin
2016-03-09 2:18 ` Linus Walleij
2016-03-09 5:37 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).