From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-renesas-soc@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Magnus Damm <magnus.damm@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms
Date: Wed, 9 Mar 2016 10:58:05 +0100 [thread overview]
Message-ID: <20160309095805.GA1506@katana> (raw)
In-Reply-To: <CAMuHMdUVFk47u+LPdfh+fq8vvPQAULyM8X_DrizCtrgf-1YwaA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]
On Mon, Mar 07, 2016 at 10:00:37PM +0100, Geert Uytterhoeven wrote:
> CC Shawn, Sascha for imx1
>
> On Mon, Mar 7, 2016 at 9:34 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > On 03/07/2016 11:29 PM, Geert Uytterhoeven wrote:
> >
> >>>>> --- a/drivers/pinctrl/sh-pfc/core.c
> >>>>> +++ b/drivers/pinctrl/sh-pfc/core.c
> >>>>> @@ -545,7 +545,9 @@ static int sh_pfc_probe(struct platform_device
> >>>>> *pdev)
> >>>>> return ret;
> >>>>> }
> >>>>>
> >>>>> - pinctrl_provide_dummies();
> >>>>> + /* Enable dummy states for those platforms without pinctrl
> >>>>> support */
> >>>>> + if (!of_have_populated_dt())
> >>>
> >>>
> >>> I'd considered this condition -- it won't fly on SH where
> >>> CONFIG_OF=n,
> >>> the kernel just won't build IIUC...
> >>
> >>
> >> I haven't tried to compile it yet, but <linux/of.h> does provide a dummy
> >> that
> >> returns false.
> >
> >
> > Oops, indeed. I missed it. :-(
> > This approach is better then, won't have to fix again whenever SH gets DT
> > support.
>
> Perhaps the of_have_populated_dt() check should be moved inside
> pinctrl_provide_dummies()?
I suggest we pick up this patch now even with stable tag (the irq storm
fixup doesn't work correctly because of this) and consider the
refactoring as a second step?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-09 9:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 18:40 [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms Wolfram Sang
2016-03-07 19:56 ` Geert Uytterhoeven
2016-03-07 20:02 ` Sergei Shtylyov
2016-03-07 20:29 ` Geert Uytterhoeven
2016-03-07 20:34 ` Sergei Shtylyov
2016-03-07 21:00 ` Geert Uytterhoeven
2016-03-07 21:19 ` Sergei Shtylyov
2016-03-08 8:15 ` Geert Uytterhoeven
2016-03-07 22:21 ` Wolfram Sang
2016-03-09 10:30 ` Linus Walleij
2016-03-09 9:58 ` Wolfram Sang [this message]
2016-03-09 10:32 ` Linus Walleij
2016-03-09 12:51 ` Sergei Shtylyov
2016-03-09 15:37 ` Wolfram Sang
2016-03-09 13:17 ` Geert Uytterhoeven
2016-03-29 5:48 ` Shawn Guo
2016-03-15 8:29 ` Linus Walleij
2016-03-15 9:08 ` Geert Uytterhoeven
2016-03-15 12:31 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309095805.GA1506@katana \
--to=wsa@the-dreams.de \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=kernel@pengutronix.de \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).