From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Matthew McClintock <mmcclint@codeaurora.org>, linus.walleij@linaro.org
Cc: andy.gross@linaro.org, linux-arm-msm@vger.kernel.org,
qca-upstream.external@qca.qualcomm.com,
Rob Herring <robh@kernel.org>,
Varadarajan Narayanan <varada@codeaurora.org>,
Mathieu Olivari <mathieu@codeaurora.org>,
"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/17] pinctrl: qcom: ipq4019: fix the function enum for gpio mode
Date: Fri, 25 Mar 2016 14:22:59 -0700 [thread overview]
Message-ID: <20160325212259.GB8929@tuxbot> (raw)
In-Reply-To: <1458770712-10880-3-git-send-email-mmcclint@codeaurora.org>
On Wed 23 Mar 15:04 PDT 2016, Matthew McClintock wrote:
> Without this, we would fail to set the mode to gpio if trying to
> configure for that mode
>
> CC: linus.walleij@linaro.org
Linus is the maintainer of the pinctrl subsystem, as such you should
have him as recipient of these patches - so that he doesn't miss them
while being only Cc.
Acked-by: bjorn.andersson@linaro.org
Regards,
Bjorn
> Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org>
> ---
> drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> index cb5f0a8..cb9f16a 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> @@ -237,7 +237,7 @@ DECLARE_QCA_GPIO_PINS(99);
> .pins = gpio##id##_pins, \
> .npins = (unsigned)ARRAY_SIZE(gpio##id##_pins), \
> .funcs = (int[]){ \
> - qca_mux_NA, /* gpio mode */ \
> + qca_mux_gpio, /* gpio mode */ \
> qca_mux_##f1, \
> qca_mux_##f2, \
> qca_mux_##f3, \
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2016-03-25 21:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1458770712-10880-1-git-send-email-mmcclint@codeaurora.org>
2016-03-23 22:04 ` [PATCH 01/17] pinctrl: qcom: ipq4019: set ngpios to correct value Matthew McClintock
2016-03-25 21:19 ` Bjorn Andersson
2016-03-31 9:53 ` Linus Walleij
2016-03-23 22:04 ` [PATCH 02/17] pinctrl: qcom: ipq4019: fix the function enum for gpio mode Matthew McClintock
2016-03-25 21:22 ` Bjorn Andersson [this message]
2016-03-31 9:55 ` Linus Walleij
2016-03-23 22:04 ` [PATCH 03/17] pinctrl: qcom: ipq4019: fix register offsets Matthew McClintock
2016-03-25 21:31 ` Bjorn Andersson
2016-03-31 9:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160325212259.GB8929@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu@codeaurora.org \
--cc=mmcclint@codeaurora.org \
--cc=qca-upstream.external@qca.qualcomm.com \
--cc=robh@kernel.org \
--cc=varada@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).