From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Tirdea, Irina" <irina.tirdea@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Purdila, Octavian" <octavian.purdila@intel.com>,
"Ciocan, Cristina" <cristina.ciocan@intel.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/4] pinctrl: Add ACPI support
Date: Tue, 5 Apr 2016 10:49:15 +0300 [thread overview]
Message-ID: <20160405074915.GD1727@lahna.fi.intel.com> (raw)
In-Reply-To: <1F3AC3675D538145B1661F571FE1805F2F22D806@irsmsx105.ger.corp.intel.com>
On Mon, Apr 04, 2016 at 02:01:13PM +0000, Tirdea, Irina wrote:
> > > + {
> > > + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > > + Package()
> > > + {
> > > + Package (2) {"pins", Package () {pin1, pin2, ...}},
> > > + Package (2) {configname1, configval1},
> >
> > These should be enclosed in quotes, like "configname1" and so on.
> >
> OK. Should all string properties be enclosed in quotes or only the property names
> (e.g. should I also change values like "configval1", "pin1", "statename1", etc.)?
I think all types should be documented using correct format. Strings
should have "" and so on.
next prev parent reply other threads:[~2016-04-05 7:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 11:44 [RFC PATCH 0/4] Add ACPI support for pinctrl configuration Irina Tirdea
2016-03-31 11:44 ` [RFC PATCH 1/4] pinctrl: Rename pinctrl_utils_dt_free_map to pinctrl_utils_free_map Irina Tirdea
2016-04-01 13:08 ` Linus Walleij
2016-03-31 11:44 ` [RFC PATCH 2/4] pinctrl: pinconf-generic: Add ACPI support Irina Tirdea
2016-04-01 14:05 ` Andy Shevchenko
2016-04-04 13:03 ` Tirdea, Irina
2016-03-31 11:44 ` [RFC PATCH 3/4] pinctrl: " Irina Tirdea
2016-04-01 14:14 ` Andy Shevchenko
2016-04-04 13:13 ` Tirdea, Irina
[not found] ` <1459424685-26965-4-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-04 13:37 ` Mika Westerberg
2016-04-04 14:01 ` Tirdea, Irina
2016-04-05 7:49 ` Mika Westerberg [this message]
2016-03-31 11:44 ` [RFC PATCH 4/4] pinctrl: Parse GpioInt/GpioIo resources Irina Tirdea
2016-04-04 13:47 ` Mika Westerberg
[not found] ` <20160404134740.GB1727-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2016-04-04 14:05 ` Tirdea, Irina
2016-04-04 21:40 ` [RFC PATCH 0/4] Add ACPI support for pinctrl configuration Mark Brown
2016-04-05 9:00 ` Linus Walleij
2016-04-05 16:12 ` Mark Brown
2016-04-05 12:51 ` Octavian Purdila
2016-04-05 17:31 ` Mark Brown
2016-04-04 22:52 ` Mark Rutland
2016-04-05 8:43 ` Linus Walleij
2016-04-05 16:59 ` Mark Brown
2016-04-05 19:37 ` Octavian Purdila
2016-04-05 22:44 ` Mark Brown
2016-04-05 23:48 ` Al Stone
2016-04-06 8:52 ` Lorenzo Pieralisi
2016-04-05 8:56 ` Charles Garcia-Tobin
2016-04-06 0:00 ` Al Stone
2016-04-06 10:49 ` Graeme Gregory
2016-04-07 14:17 ` Octavian Purdila
2016-04-07 18:01 ` Linus Walleij
2016-04-05 15:33 ` Tirdea, Irina
2016-04-05 18:16 ` Mark Rutland
2016-04-05 20:09 ` Octavian Purdila
2016-04-06 0:01 ` Mark Rutland
2016-04-07 12:11 ` Octavian Purdila
2016-04-06 10:39 ` Mark Rutland
2016-04-07 21:24 ` Rafael J. Wysocki
2016-04-12 12:15 ` Mark Brown
2016-04-13 5:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405074915.GD1727@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cristina.ciocan@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=irina.tirdea@intel.com \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).