From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH V2 2/7] cpufreq: Loongson1: Update cpufreq of Loongson1B Date: Mon, 11 Apr 2016 09:22:11 +0530 Message-ID: <20160411035211.GA16238@vireshk-i7> References: <1460115779-13141-1-git-send-email-keguang.zhang@gmail.com> <1460115779-13141-2-git-send-email-keguang.zhang@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1460115779-13141-2-git-send-email-keguang.zhang@gmail.com> Sender: linux-clk-owner@vger.kernel.org To: Keguang Zhang Cc: linux-mips@linux-mips.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, dmaengine@vger.kernel.org, linux-gpio@vger.kernel.org, linux-mtd@lists.infradead.org, Ralf Baechle , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Vinod Koul , Dan Williams , Linus Walleij , Alexandre Courbot , Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris List-Id: linux-gpio@vger.kernel.org On 08-04-16, 19:42, Keguang Zhang wrote: > From: Kelvin Cheung > > - Rename the file to loongson1-cpufreq.c > - Use kcalloc() instead of kzalloc() > - Use devm_kzalloc() instead of global structure > - Use dev_get_platdata() to access the platform_data field > instead of referencing it directly > - Remove superfluous error messages Its much better now, in the sense that I can see what you have done. And see you have done a lot. That's not how you are supposed to send the patches, sorry. You need to break this patch into multiple patches, each targeting a particular fix. And I have no idea now, what change you have done to make it work for Loongson1B. Which of the above changes does that? And please, just send out a separate cpufreq series and don't send everything in a single patchset that covers DMA, cpufreq, clk, etc.. -- viresh