From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>,
patches@opensource.wolfsonmicro.com,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 2/2] gpio: wm8994: use the new open drain callback
Date: Tue, 12 Apr 2016 09:00:05 +0100 [thread overview]
Message-ID: <20160412080005.GR31814@localhost.localdomain> (raw)
In-Reply-To: <1460446189-16444-1-git-send-email-linus.walleij@linaro.org>
On Tue, Apr 12, 2016 at 09:29:49AM +0200, Linus Walleij wrote:
> The WM8994 GPIOs clearly have a dedicated open drain control
> register. Implement support for controlling this from GPIO
> descriptor tables or other hardware descriptions such as
> device tree by implementing the .set_single_ended() callback.
>
> Before this patch, lines requesting open drain will just be
> switched to input mode by the framework, thus emulating open
> drain. But the hardware can do the real thing, so let's
> support that.
>
> As part of this, rename the debugfs string for output mode
> from "CMOS" to "push-pull" because it is the term used in
> the framework to signify a tomem-pole CMOS output.
>
> Cc: patches@opensource.wolfsonmicro.com
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2016-04-12 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 7:29 [PATCH 2/2] gpio: wm8994: use the new open drain callback Linus Walleij
2016-04-12 8:00 ` Charles Keepax [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-10 13:12 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412080005.GR31814@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=acourbot@nvidia.com \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).