From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH 2/2] gpio: wm8994: use the new open drain callback Date: Tue, 12 Apr 2016 09:00:05 +0100 Message-ID: <20160412080005.GR31814@localhost.localdomain> References: <1460446189-16444-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:58586 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932223AbcDLIAB (ORCPT ); Tue, 12 Apr 2016 04:00:01 -0400 Content-Disposition: inline In-Reply-To: <1460446189-16444-1-git-send-email-linus.walleij@linaro.org> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: linux-gpio@vger.kernel.org, Alexandre Courbot , patches@opensource.wolfsonmicro.com, Mark Brown On Tue, Apr 12, 2016 at 09:29:49AM +0200, Linus Walleij wrote: > The WM8994 GPIOs clearly have a dedicated open drain control > register. Implement support for controlling this from GPIO > descriptor tables or other hardware descriptions such as > device tree by implementing the .set_single_ended() callback. > > Before this patch, lines requesting open drain will just be > switched to input mode by the framework, thus emulating open > drain. But the hardware can do the real thing, so let's > support that. > > As part of this, rename the debugfs string for output mode > from "CMOS" to "push-pull" because it is the term used in > the framework to signify a tomem-pole CMOS output. > > Cc: patches@opensource.wolfsonmicro.com > Cc: Mark Brown > Cc: Charles Keepax > Signed-off-by: Linus Walleij > --- Acked-by: Charles Keepax Thanks, Charles