From: Shawn Guo <shawnguo@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Frank Li <Frank.Li@freescale.com>,
Anson Huang <b20788@freescale.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: imx: select regmap subsystem
Date: Mon, 18 Apr 2016 09:44:32 +0800 [thread overview]
Message-ID: <20160418014432.GQ28903@tiger> (raw)
In-Reply-To: <1460838382-1245338-1-git-send-email-arnd@arndb.de>
On Sat, Apr 16, 2016 at 10:26:06PM +0200, Arnd Bergmann wrote:
> Building the imx pinctrl driver without regmap fails with multiple
> build errors like:
>
> drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_probe':
> drivers/pinctrl/freescale/pinctrl-imx.c:723:9: error: variable 'config' has initializer but incomplete type
> struct regmap_config config = { .name = "gpr" };
>
> This adds a 'select REGMAP' statement, to ensure we can define a 'struct
> regmap_config'. This matches what all other regmap users do. The driver
> actually uses syscon on top of regmap, but syscon is already enabled
> on i.MX for other reasons, and selecting REGMAP but not SYSCON is
> sufficient for build testing on other platforms.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")
LinusW already applied a similar patch [1] from Alexander a few days
ago.
Shawn
[1] http://thread.gmane.org/gmane.linux.kernel.gpio/16054
prev parent reply other threads:[~2016-04-18 1:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 20:26 [PATCH] pinctrl: imx: select regmap subsystem Arnd Bergmann
2016-04-18 1:44 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418014432.GQ28903@tiger \
--to=shawnguo@kernel.org \
--cc=Frank.Li@freescale.com \
--cc=arnd@arndb.de \
--cc=b20788@freescale.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).