* [PATCH] pinctrl: imx: select regmap subsystem
@ 2016-04-16 20:26 Arnd Bergmann
2016-04-18 1:44 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-04-16 20:26 UTC (permalink / raw)
To: Linus Walleij
Cc: Philipp Zabel, Arnd Bergmann, Frank Li, Anson Huang, Shawn Guo,
linux-gpio, linux-kernel
Building the imx pinctrl driver without regmap fails with multiple
build errors like:
drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_probe':
drivers/pinctrl/freescale/pinctrl-imx.c:723:9: error: variable 'config' has initializer but incomplete type
struct regmap_config config = { .name = "gpr" };
This adds a 'select REGMAP' statement, to ensure we can define a 'struct
regmap_config'. This matches what all other regmap users do. The driver
actually uses syscon on top of regmap, but syscon is already enabled
on i.MX for other reasons, and selecting REGMAP but not SYSCON is
sufficient for build testing on other platforms.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")
---
drivers/pinctrl/freescale/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
index debe1219d76d..fc8cbf611723 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -2,6 +2,7 @@ config PINCTRL_IMX
bool
select PINMUX
select PINCONF
+ select REGMAP
config PINCTRL_IMX1_CORE
bool
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: imx: select regmap subsystem
2016-04-16 20:26 [PATCH] pinctrl: imx: select regmap subsystem Arnd Bergmann
@ 2016-04-18 1:44 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2016-04-18 1:44 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, Philipp Zabel, Frank Li, Anson Huang, linux-gpio,
linux-kernel
On Sat, Apr 16, 2016 at 10:26:06PM +0200, Arnd Bergmann wrote:
> Building the imx pinctrl driver without regmap fails with multiple
> build errors like:
>
> drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_probe':
> drivers/pinctrl/freescale/pinctrl-imx.c:723:9: error: variable 'config' has initializer but incomplete type
> struct regmap_config config = { .name = "gpr" };
>
> This adds a 'select REGMAP' statement, to ensure we can define a 'struct
> regmap_config'. This matches what all other regmap users do. The driver
> actually uses syscon on top of regmap, but syscon is already enabled
> on i.MX for other reasons, and selecting REGMAP but not SYSCON is
> sufficient for build testing on other platforms.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")
LinusW already applied a similar patch [1] from Alexander a few days
ago.
Shawn
[1] http://thread.gmane.org/gmane.linux.kernel.gpio/16054
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-18 1:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-16 20:26 [PATCH] pinctrl: imx: select regmap subsystem Arnd Bergmann
2016-04-18 1:44 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).