* [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly
@ 2016-04-22 19:38 ville.syrjala
2016-04-25 7:40 ` Jani Nikula
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: ville.syrjala @ 2016-04-22 19:38 UTC (permalink / raw)
To: linux-gpio
Cc: intel-gfx, Shobhit Kumar, Samuel Ortiz, Linus Walleij,
Alexandre Courbot, Thierry Reding, Lee Jones, stable
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
GPIO lookup tables are supposed to be zero terminated. Let's do that
and avoid accidentally walking off the end.
Cc: Shobhit Kumar <shobhit.kumar@intel.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: stable@vger.kernel.org
Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/mfd/intel_soc_pmic_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
index d9e15cf7c6c8..12d6ebb4ae5d 100644
--- a/drivers/mfd/intel_soc_pmic_core.c
+++ b/drivers/mfd/intel_soc_pmic_core.c
@@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = {
.table = {
/* Panel EN/DISABLE */
GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
+ { },
},
};
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly
2016-04-22 19:38 [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly ville.syrjala
@ 2016-04-25 7:40 ` Jani Nikula
2016-04-25 10:06 ` Thierry Reding
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Jani Nikula @ 2016-04-25 7:40 UTC (permalink / raw)
To: ville.syrjala, linux-gpio
Cc: Alexandre Courbot, Samuel Ortiz, Shobhit Kumar, intel-gfx, stable,
Thierry Reding, Lee Jones, Linus Walleij
On Fri, 22 Apr 2016, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> GPIO lookup tables are supposed to be zero terminated. Let's do that
> and avoid accidentally walking off the end.
>
> Cc: Shobhit Kumar <shobhit.kumar@intel.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: stable@vger.kernel.org
> Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/mfd/intel_soc_pmic_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index d9e15cf7c6c8..12d6ebb4ae5d 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = {
> .table = {
> /* Panel EN/DISABLE */
> GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
> + { },
> },
> };
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly
2016-04-22 19:38 [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly ville.syrjala
2016-04-25 7:40 ` Jani Nikula
@ 2016-04-25 10:06 ` Thierry Reding
2016-04-29 9:31 ` Linus Walleij
2016-05-09 7:18 ` Lee Jones
3 siblings, 0 replies; 9+ messages in thread
From: Thierry Reding @ 2016-04-25 10:06 UTC (permalink / raw)
To: ville.syrjala
Cc: linux-gpio, intel-gfx, Shobhit Kumar, Samuel Ortiz, Linus Walleij,
Alexandre Courbot, Lee Jones, stable
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On Fri, Apr 22, 2016 at 10:38:55PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> GPIO lookup tables are supposed to be zero terminated. Let's do that
> and avoid accidentally walking off the end.
>
> Cc: Shobhit Kumar <shobhit.kumar@intel.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: stable@vger.kernel.org
> Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/mfd/intel_soc_pmic_core.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly
2016-04-22 19:38 [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly ville.syrjala
2016-04-25 7:40 ` Jani Nikula
2016-04-25 10:06 ` Thierry Reding
@ 2016-04-29 9:31 ` Linus Walleij
2016-05-02 8:19 ` Daniel Vetter
2016-05-09 7:18 ` Lee Jones
3 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2016-04-29 9:31 UTC (permalink / raw)
To: Ville Syrjälä
Cc: linux-gpio@vger.kernel.org, intel-gfx, Shobhit Kumar,
Samuel Ortiz, Alexandre Courbot, Thierry Reding, Lee Jones,
stable
On Fri, Apr 22, 2016 at 9:38 PM, <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> GPIO lookup tables are supposed to be zero terminated. Let's do that
> and avoid accidentally walking off the end.
>
> Cc: Shobhit Kumar <shobhit.kumar@intel.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: stable@vger.kernel.org
> Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly
2016-04-29 9:31 ` Linus Walleij
@ 2016-05-02 8:19 ` Daniel Vetter
2016-05-04 7:32 ` Lee Jones
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Vetter @ 2016-05-02 8:19 UTC (permalink / raw)
To: Linus Walleij
Cc: Alexandre Courbot, Samuel Ortiz, Shobhit Kumar, intel-gfx, stable,
linux-gpio@vger.kernel.org, Thierry Reding, Lee Jones
On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote:
> On Fri, Apr 22, 2016 at 9:38 PM, <ville.syrjala@linux.intel.com> wrote:
>
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > GPIO lookup tables are supposed to be zero terminated. Let's do that
> > and avoid accidentally walking off the end.
> >
> > Cc: Shobhit Kumar <shobhit.kumar@intel.com>
> > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Alexandre Courbot <gnurou@gmail.com>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: stable@vger.kernel.org
> > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Applied to drm-intel trees, thanks for patch, reviews&acks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly
2016-05-02 8:19 ` Daniel Vetter
@ 2016-05-04 7:32 ` Lee Jones
2016-05-09 6:57 ` Daniel Vetter
0 siblings, 1 reply; 9+ messages in thread
From: Lee Jones @ 2016-05-04 7:32 UTC (permalink / raw)
To: Daniel Vetter
Cc: Alexandre Courbot, Samuel Ortiz, Shobhit Kumar, Linus Walleij,
stable, linux-gpio@vger.kernel.org, Thierry Reding, intel-gfx
On Mon, 02 May 2016, Daniel Vetter wrote:
> On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote:
> > On Fri, Apr 22, 2016 at 9:38 PM, <ville.syrjala@linux.intel.com> wrote:
> >
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > GPIO lookup tables are supposed to be zero terminated. Let's do that
> > > and avoid accidentally walking off the end.
> > >
> > > Cc: Shobhit Kumar <shobhit.kumar@intel.com>
> > > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > > Cc: Linus Walleij <linus.walleij@linaro.org>
> > > Cc: Alexandre Courbot <gnurou@gmail.com>
> > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > Cc: Lee Jones <lee.jones@linaro.org>
> > > Cc: stable@vger.kernel.org
> > > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal")
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Applied to drm-intel trees, thanks for patch, reviews&acks.
Do what now? How can you apply a patch for a subsystem you don't have
responsibility for? This is bound to cause merge conflicts.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly
2016-05-04 7:32 ` Lee Jones
@ 2016-05-09 6:57 ` Daniel Vetter
2016-05-09 7:17 ` [Intel-gfx] " Lee Jones
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Vetter @ 2016-05-09 6:57 UTC (permalink / raw)
To: Lee Jones
Cc: Alexandre Courbot, Samuel Ortiz, Shobhit Kumar, Linus Walleij,
stable, linux-gpio@vger.kernel.org, Thierry Reding, intel-gfx
On Wed, May 04, 2016 at 08:32:17AM +0100, Lee Jones wrote:
> On Mon, 02 May 2016, Daniel Vetter wrote:
>
> > On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote:
> > > On Fri, Apr 22, 2016 at 9:38 PM, <ville.syrjala@linux.intel.com> wrote:
> > >
> > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > >
> > > > GPIO lookup tables are supposed to be zero terminated. Let's do that
> > > > and avoid accidentally walking off the end.
> > > >
> > > > Cc: Shobhit Kumar <shobhit.kumar@intel.com>
> > > > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > > > Cc: Linus Walleij <linus.walleij@linaro.org>
> > > > Cc: Alexandre Courbot <gnurou@gmail.com>
> > > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > > Cc: Lee Jones <lee.jones@linaro.org>
> > > > Cc: stable@vger.kernel.org
> > > > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal")
> > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Applied to drm-intel trees, thanks for patch, reviews&acks.
>
> Do what now? How can you apply a patch for a subsystem you don't have
> responsibility for? This is bound to cause merge conflicts.
Oh crap, I thought Linus' ack was for the mfd stuff and didn't bother
double-checking with MAINTAINTERS. Should I throw it out again and you'll
pick it up, or ok as such?
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly
2016-05-09 6:57 ` Daniel Vetter
@ 2016-05-09 7:17 ` Lee Jones
0 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2016-05-09 7:17 UTC (permalink / raw)
To: Daniel Vetter
Cc: Linus Walleij, Ville Syrjälä, Alexandre Courbot,
Samuel Ortiz, Shobhit Kumar, intel-gfx, stable,
linux-gpio@vger.kernel.org, Thierry Reding
On Mon, 09 May 2016, Daniel Vetter wrote:
> On Wed, May 04, 2016 at 08:32:17AM +0100, Lee Jones wrote:
> > On Mon, 02 May 2016, Daniel Vetter wrote:
> >
> > > On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote:
> > > > On Fri, Apr 22, 2016 at 9:38 PM, <ville.syrjala@linux.intel.com> wrote:
> > > >
> > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > >
> > > > > GPIO lookup tables are supposed to be zero terminated. Let's do that
> > > > > and avoid accidentally walking off the end.
> > > > >
> > > > > Cc: Shobhit Kumar <shobhit.kumar@intel.com>
> > > > > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > > > > Cc: Linus Walleij <linus.walleij@linaro.org>
> > > > > Cc: Alexandre Courbot <gnurou@gmail.com>
> > > > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > > > Cc: Lee Jones <lee.jones@linaro.org>
> > > > > Cc: stable@vger.kernel.org
> > > > > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal")
> > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > >
> > > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > >
> > > Applied to drm-intel trees, thanks for patch, reviews&acks.
> >
> > Do what now? How can you apply a patch for a subsystem you don't have
> > responsibility for? This is bound to cause merge conflicts.
>
> Oh crap, I thought Linus' ack was for the mfd stuff and didn't bother
> double-checking with MAINTAINTERS. Should I throw it out again and you'll
> pick it up, or ok as such?
Yes please.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly
2016-04-22 19:38 [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly ville.syrjala
` (2 preceding siblings ...)
2016-04-29 9:31 ` Linus Walleij
@ 2016-05-09 7:18 ` Lee Jones
3 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2016-05-09 7:18 UTC (permalink / raw)
To: ville.syrjala
Cc: Alexandre Courbot, Samuel Ortiz, Shobhit Kumar, intel-gfx, stable,
linux-gpio, Thierry Reding, Linus Walleij
On Fri, 22 Apr 2016, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> GPIO lookup tables are supposed to be zero terminated. Let's do that
> and avoid accidentally walking off the end.
>
> Cc: Shobhit Kumar <shobhit.kumar@intel.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: stable@vger.kernel.org
> Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/mfd/intel_soc_pmic_core.c | 1 +
> 1 file changed, 1 insertion(+)
Applied with Linus' and Daniel's Ack.
> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index d9e15cf7c6c8..12d6ebb4ae5d 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = {
> .table = {
> /* Panel EN/DISABLE */
> GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
> + { },
> },
> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-05-09 7:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-22 19:38 [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly ville.syrjala
2016-04-25 7:40 ` Jani Nikula
2016-04-25 10:06 ` Thierry Reding
2016-04-29 9:31 ` Linus Walleij
2016-05-02 8:19 ` Daniel Vetter
2016-05-04 7:32 ` Lee Jones
2016-05-09 6:57 ` Daniel Vetter
2016-05-09 7:17 ` [Intel-gfx] " Lee Jones
2016-05-09 7:18 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).