From: Lee Jones <lee.jones@linaro.org>
To: ville.syrjala@linux.intel.com
Cc: Alexandre Courbot <gnurou@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Shobhit Kumar <shobhit.kumar@intel.com>,
intel-gfx@lists.freedesktop.org, stable@vger.kernel.org,
linux-gpio@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly
Date: Mon, 9 May 2016 08:18:32 +0100 [thread overview]
Message-ID: <20160509071832.GA8324@dell> (raw)
In-Reply-To: <1461353935-8078-1-git-send-email-ville.syrjala@linux.intel.com>
On Fri, 22 Apr 2016, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> GPIO lookup tables are supposed to be zero terminated. Let's do that
> and avoid accidentally walking off the end.
>
> Cc: Shobhit Kumar <shobhit.kumar@intel.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: stable@vger.kernel.org
> Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/mfd/intel_soc_pmic_core.c | 1 +
> 1 file changed, 1 insertion(+)
Applied with Linus' and Daniel's Ack.
> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index d9e15cf7c6c8..12d6ebb4ae5d 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = {
> .table = {
> /* Panel EN/DISABLE */
> GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
> + { },
> },
> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-05-09 7:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 19:38 [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly ville.syrjala
2016-04-25 7:40 ` Jani Nikula
2016-04-25 10:06 ` Thierry Reding
2016-04-29 9:31 ` Linus Walleij
2016-05-02 8:19 ` Daniel Vetter
2016-05-04 7:32 ` Lee Jones
2016-05-09 6:57 ` Daniel Vetter
2016-05-09 7:17 ` [Intel-gfx] " Lee Jones
2016-05-09 7:18 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509071832.GA8324@dell \
--to=lee.jones@linaro.org \
--cc=gnurou@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=shobhit.kumar@intel.com \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).