From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call Date: Wed, 25 May 2016 09:48:32 +0300 Message-ID: <20160525064832.GG2178@tarshish> References: <1464155932-25344-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1464155932-25344-1-git-send-email-yamada.masahiro@socionext.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Masahiro Yamada Cc: linux-gpio@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-gpio@vger.kernel.org Hi Masahiro Yamada, On Wed, May 25, 2016 at 02:58:52PM +0900, Masahiro Yamada wrote: > gc_pinctrl_remove() calls platform_get_drvdata(), but I see neither > platform_set_drvdata() nor dev_set_drvdata() anywhere in this driver. > > Signed-off-by: Masahiro Yamada Acked-by: Baruch Siach Thanks, baruch > drivers/pinctrl/pinctrl-digicolor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c > index 30ee564..c8073d4 100644 > --- a/drivers/pinctrl/pinctrl-digicolor.c > +++ b/drivers/pinctrl/pinctrl-digicolor.c > @@ -332,6 +332,8 @@ static int dc_pinctrl_probe(struct platform_device *pdev) > return PTR_ERR(pmap->pctl); > } > > + platform_set_drvdata(pdev, pmap); > + > return dc_gpiochip_add(pmap, pdev->dev.of_node); > } -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -