* [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call
@ 2016-05-25 5:58 Masahiro Yamada
2016-05-25 6:48 ` Baruch Siach
2016-05-31 8:31 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2016-05-25 5:58 UTC (permalink / raw)
To: linux-gpio
Cc: Masahiro Yamada, Baruch Siach, Linus Walleij, linux-kernel,
linux-arm-kernel
gc_pinctrl_remove() calls platform_get_drvdata(), but I see neither
platform_set_drvdata() nor dev_set_drvdata() anywhere in this driver.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/pinctrl/pinctrl-digicolor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
index 30ee564..c8073d4 100644
--- a/drivers/pinctrl/pinctrl-digicolor.c
+++ b/drivers/pinctrl/pinctrl-digicolor.c
@@ -332,6 +332,8 @@ static int dc_pinctrl_probe(struct platform_device *pdev)
return PTR_ERR(pmap->pctl);
}
+ platform_set_drvdata(pdev, pmap);
+
return dc_gpiochip_add(pmap, pdev->dev.of_node);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call
2016-05-25 5:58 [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call Masahiro Yamada
@ 2016-05-25 6:48 ` Baruch Siach
2016-05-31 8:31 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2016-05-25 6:48 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-gpio, Linus Walleij, linux-kernel, linux-arm-kernel
Hi Masahiro Yamada,
On Wed, May 25, 2016 at 02:58:52PM +0900, Masahiro Yamada wrote:
> gc_pinctrl_remove() calls platform_get_drvdata(), but I see neither
> platform_set_drvdata() nor dev_set_drvdata() anywhere in this driver.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> drivers/pinctrl/pinctrl-digicolor.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
> index 30ee564..c8073d4 100644
> --- a/drivers/pinctrl/pinctrl-digicolor.c
> +++ b/drivers/pinctrl/pinctrl-digicolor.c
> @@ -332,6 +332,8 @@ static int dc_pinctrl_probe(struct platform_device *pdev)
> return PTR_ERR(pmap->pctl);
> }
>
> + platform_set_drvdata(pdev, pmap);
> +
> return dc_gpiochip_add(pmap, pdev->dev.of_node);
> }
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call
2016-05-25 5:58 [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call Masahiro Yamada
2016-05-25 6:48 ` Baruch Siach
@ 2016-05-31 8:31 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-05-31 8:31 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-gpio@vger.kernel.org, Baruch Siach,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
On Wed, May 25, 2016 at 7:58 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> gc_pinctrl_remove() calls platform_get_drvdata(), but I see neither
> platform_set_drvdata() nor dev_set_drvdata() anywhere in this driver.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Patch applied with Baruch's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-31 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-25 5:58 [PATCH] pinctrl: digicolor: add missing platform_set_drvdata() call Masahiro Yamada
2016-05-25 6:48 ` Baruch Siach
2016-05-31 8:31 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).