From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v2 2/4] gpio: Allow PC/104 devices on X86_64 Date: Fri, 3 Jun 2016 22:57:03 +0200 Message-ID: <20160603205703.GC11253@amd> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:55794 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751919AbcFCU5I (ORCPT ); Fri, 3 Jun 2016 16:57:08 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: William Breathitt Gray Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org, x86@kernel.org, linux-next@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Guenter Roeck , Linus Walleij Hi! > With the introduction of the ISA_BUS_API Kconfig option, ISA-style > drivers may be built for X86_64 architectures. This patch changes the > ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus > allowing them to build for X86_64 as they are expected to. > > Cc: Guenter Roeck > Cc: Linus Walleij > Signed-off-by: William Breathitt Gray > --- > drivers/gpio/Kconfig | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 48da857..dc6da77 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -530,7 +530,7 @@ menu "Port-mapped I/O GPIO drivers" > > config GPIO_104_DIO_48E > tristate "ACCES 104-DIO-48E GPIO support" > - depends on ISA > + depends on ISA_BUS_API > select GPIOLIB_IRQCHIP > help > Enables GPIO support for the ACCES 104-DIO-48E series Should we do "depends on PC104" here, because that is what it really means, and have PC104 enabled when ISA_BUS_API is enabled or something like that? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html