From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v3 2/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's Date: Tue, 21 Jun 2016 10:23:39 +0300 Message-ID: <20160621072339.GT1739@lahna.fi.intel.com> References: <1465282553-28396-1-git-send-email-jui.nee.tan@intel.com> <1465282553-28396-3-git-send-email-jui.nee.tan@intel.com> <20160609140538.GL1791@lahna.fi.intel.com> <1465826071.30123.18.camel@linux.intel.com> <20160613142514.GA1740@lahna.fi.intel.com> <1465831152.30123.21.camel@linux.intel.com> <20160613155907.GB1740@lahna.fi.intel.com> <0158A29DB680F54A88142ED28D55B1D008244AF1@PGSMSX107.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga11.intel.com ([192.55.52.93]:35357 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932550AbcFUH0S (ORCPT ); Tue, 21 Jun 2016 03:26:18 -0400 Content-Disposition: inline In-Reply-To: <0158A29DB680F54A88142ED28D55B1D008244AF1@PGSMSX107.gar.corp.intel.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: "Tan, Jui Nee" Cc: Andy Shevchenko , "heikki.krogerus@linux.intel.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "ptyser@xes-inc.com" , "lee.jones@linaro.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linus Walleij , "Yong, Jonathan" , "Yu, Ong Hock" , "Voon, Weifeng" , "Wan Mohamad, Wan Ahmad Zainie" On Tue, Jun 21, 2016 at 05:03:20AM +0000, Tan, Jui Nee wrote: > > Maybe, or make it modular and use MODULE_DEVICE_TABLE(x86cpu, ...) to > > match the corresponding CPUs. > > We need CONFIG_X86_INTEL_NON_ACPI Kconfig option to select CONFIG_PINCTRL. > This is to solve kbuidbot complaint about kernel configuration, i.e. > CONFIG_PINCTRL=n. Appreciate if you could advise something on this. Good point. Then I guess you might add similar Kconfig option but can you call it something else than CONFIG_X86_INTEL_NON_ACPI. Perhaps something that relates to the actual product so distro people can then decide whether they want to support it or not. Along the lines of CONFIG_X86_INTEL_CE and so on.