From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [RFC] pinctrl: sh-pfc: propagate errors on group config
Date: Tue, 21 Jun 2016 22:37:08 +0200 [thread overview]
Message-ID: <20160621203707.GB1682@katana> (raw)
In-Reply-To: <CAMuHMdXWwZaCoLz8TTLBVg8qmKpiw0wKGUawd6ti0wg3X5e6xA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
> > On group configuration, bail out if setting one of the individual pins
> > fails. We don't need to roll-back, the pinctrl core will do this for us.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > ---
> >
> > Tested on a Lager and Salvator-X without problems. Needs probably more testing
> > on various HW to avoid regressions?
>
> Your patch causes the display to fail on r8a7740/armadillo.
I would have been surprised if this patch didn't uncover some hidden
issues.
> 15 = PIN_CONFIG_OUTPUT
>
> No idea why this is set for all pins of the lcd0_data24_0 group (and not for any
> other pin or group on any other SoC).
Me neither. Sadly no bandwith here to dig into it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-21 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 6:40 [RFC] pinctrl: sh-pfc: propagate errors on group config Wolfram Sang
2016-06-21 13:11 ` Geert Uytterhoeven
2016-06-21 20:37 ` Wolfram Sang [this message]
2017-05-24 11:47 ` Geert Uytterhoeven
2017-05-24 12:21 ` Wolfram Sang
2017-05-24 12:27 ` Geert Uytterhoeven
2017-07-17 8:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621203707.GB1682@katana \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox