From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org
Subject: [PATCH 19/19] pinctrl: remove orphaned exported ".remove" function
Date: Sat, 25 Jun 2016 22:46:52 -0400 [thread overview]
Message-ID: <20160626024652.5081-20-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160626024652.5081-1-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
drivers/pinctrl/freescale/Kconfig:config PINCTRL_MXS
drivers/pinctrl/freescale/Kconfig: bool
...meaning that it currently is not being built as a module by anyone.
It also doesn't have any modular functionality, so it doesn't need
module.h included at all.
What it does have is an exported function that was used as a shared
".remove" by other drivers, but those use cases (imx23 and imx28)
are now gone, and hence this can disappear as well.
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/pinctrl/freescale/pinctrl-mxs.c | 12 ------------
drivers/pinctrl/freescale/pinctrl-mxs.h | 1 -
2 files changed, 13 deletions(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-mxs.c b/drivers/pinctrl/freescale/pinctrl-mxs.c
index 6bbda6b4ab50..41b5b07d5a2b 100644
--- a/drivers/pinctrl/freescale/pinctrl-mxs.c
+++ b/drivers/pinctrl/freescale/pinctrl-mxs.c
@@ -12,7 +12,6 @@
#include <linux/err.h>
#include <linux/init.h>
#include <linux/io.h>
-#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/pinctrl/machine.h>
@@ -553,14 +552,3 @@ err:
return ret;
}
EXPORT_SYMBOL_GPL(mxs_pinctrl_probe);
-
-int mxs_pinctrl_remove(struct platform_device *pdev)
-{
- struct mxs_pinctrl_data *d = platform_get_drvdata(pdev);
-
- pinctrl_unregister(d->pctl);
- iounmap(d->base);
-
- return 0;
-}
-EXPORT_SYMBOL_GPL(mxs_pinctrl_remove);
diff --git a/drivers/pinctrl/freescale/pinctrl-mxs.h b/drivers/pinctrl/freescale/pinctrl-mxs.h
index fdd88d0bae22..34dbf75208dc 100644
--- a/drivers/pinctrl/freescale/pinctrl-mxs.h
+++ b/drivers/pinctrl/freescale/pinctrl-mxs.h
@@ -86,6 +86,5 @@ struct mxs_pinctrl_soc_data {
int mxs_pinctrl_probe(struct platform_device *pdev,
struct mxs_pinctrl_soc_data *soc);
-int mxs_pinctrl_remove(struct platform_device *pdev);
#endif /* __PINCTRL_MXS_H */
--
2.8.4
next prev parent reply other threads:[~2016-06-26 2:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 2:46 [PATCH 00/19] pinctrl/freescale: fix module usage in non-modular code Paul Gortmaker
2016-06-26 2:46 ` [PATCH 01/19] pinctrl: freescale: remove needless module.h include Paul Gortmaker
2016-06-29 7:30 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 02/19] pinctrl: imx1: make it explicitly non-modular Paul Gortmaker
2016-06-29 7:31 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 03/19] pinctrl: imx21: " Paul Gortmaker
2016-06-29 7:32 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 04/19] pinctrl: imx25: " Paul Gortmaker
2016-06-29 7:33 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 05/19] pinctrl: imx27: " Paul Gortmaker
2016-06-29 7:34 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 06/19] pinctrl: imx35: " Paul Gortmaker
2016-06-29 7:35 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 07/19] pinctrl: imx50: " Paul Gortmaker
2016-06-29 7:36 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 08/19] pinctrl: imx51: " Paul Gortmaker
2016-06-29 7:37 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 09/19] pinctrl: imx53: " Paul Gortmaker
2016-06-29 7:38 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 10/19] pinctrl: imx6dl: " Paul Gortmaker
2016-06-29 7:39 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 11/19] pinctrl: imx6q: " Paul Gortmaker
2016-06-29 7:49 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 12/19] pinctrl: imx6sl: " Paul Gortmaker
2016-06-29 7:50 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 13/19] pinctrl: imx6sx: " Paul Gortmaker
2016-06-29 7:51 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 14/19] pinctrl: imx6ul: " Paul Gortmaker
2016-06-29 7:52 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 15/19] pinctrl: imx7d: " Paul Gortmaker
2016-06-29 7:53 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 16/19] pinctrl: vf610: " Paul Gortmaker
2016-06-29 7:54 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 17/19] pinctrl: imx23: " Paul Gortmaker
2016-06-29 7:55 ` Linus Walleij
2016-06-26 2:46 ` [PATCH 18/19] pinctrl: imx28: " Paul Gortmaker
2016-06-29 7:55 ` Linus Walleij
2016-06-26 2:46 ` Paul Gortmaker [this message]
2016-06-29 7:56 ` [PATCH 19/19] pinctrl: remove orphaned exported ".remove" function Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160626024652.5081-20-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).